Full focal plane infrastructure#495

Open

welucas2 wants to merge 36 commits intomainfrom

u/welucas2/full-focal-plane

Commits on Mar 26, 2026

Machinery to write photons outside image bounds as extra output to FITS.
welucas2
committed
Put scattered photons in focal plane coords.
welucas2
committed
First partial attempt at reading in the photons from file.
welucas2
committed
Working scattered photon input
welucas2
committed
Initial full working pipeline
welucas2
committed
Full focal plane tests
welucas2
committed
Move gathering of scattered photons into new function in photon_scattering.py
welucas2
committed
Initial go at code to find a science detectors neighbours as part of the Camera class.
welucas2
committed
Make references to 'scattered' photons 'off-detector' photons instead -- more general, as we don't want to presume how they got off the detector. Be a bit more general.
welucas2
committed
Rename photon_scattering.py to full_focal_plane.py
welucas2
committed
Changes to variable names in get_adjacent_detectors()
welucas2
committed
Move off detector photons from photon pooling config to FFP pass 1 example
welucas2
committed
Doing some horrible initial experimentation in instcat.py.
welucas2
committed
Make the fiducial WCS a component of the instcat in the YAML config.
welucas2
committed
Big improvements to the instcat multi detector object handling. And it now works.
welucas2
committed
First go at getting skyCatalog interface to accept/reject objects by proximity to detector.
welucas2
committed
Add example_instance_catalog_ffp.txt
welucas2
committed
Add the fiducial WCS to imsim-config-skycat.yaml.
welucas2
committed
First attempt at logic to filter out objects closer to other dets in skycat.py
welucas2
committed
keep track of objects to skip instead of trying to use an iterator provided by the filter built-in

jchiang87
authored and
welucas2
committed
include f-string prefix

jchiang87
authored and
welucas2
committed
don't run AddNoise for pass 2 rendering

jchiang87
authored and
welucas2
committed
Config now keys off-detector photons to det_num/name.
welucas2
committed
Fix test_trimmer.py to set edge_pix=100, the old default, to keep a test useful. (Default is now 200 pixels to cover the gap between detectors.)
welucas2
committed
New input.instance_catalog.full_focal_plane enables and disables FFP.
welucas2
committed
Have test_image_nobjects set edge_pix=100 as the new default of 200 (to fill detector gaps) changes results.
welucas2
committed
Calculate fiducial WCS before image WCS in order to correctly store _icrf_to_field in base config.
welucas2
committed
Add full_focal_plane parameter to skycat and ensure correct _icrf_to_field is stored.
welucas2
committed
Allow off_detector_photons to be read from multiple files.
welucas2
committed
Update tests to use LsstCamSim.
welucas2
committed
Fix edge_pix values used in test_stamp.py to old value of 100.
welucas2
committed
Add tests for off-detector photon loader.
welucas2
committed
New test for LSST_FocalPlaneImage.
welucas2
committed
Rework off-detector photons input to lazily read photons and also allow them to be manually set if desired, with what are hopefully appropriate warnings along the way.
welucas2
committed
Minor tidying up in the second pass example config.
welucas2
committed
Add files in tests/data for new full focal plane tests.
welucas2
committed