Have flats use camera info for image sizes#510
Merged
Conversation
…imsim-config.yaml
…t levels can be controlled by exposure time
rmjarvis
approved these changes
Mar 19, 2026
Contributor
rmjarvis
left a comment
rmjarvis
left a comment
There was a problem hiding this comment.
This is all fine. Just one minor suggestion.
| self.counts_per_pixel = params['counts_per_pixel'] | ||
| else: | ||
| exptime = base['exptime'] | ||
| self.counts_per_pixel = params['countrate_per_pixel']*exptime |
Contributor
There was a problem hiding this comment.
Maybe worth checking that counts_per_pixel isn't also set here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will enable generating flat/ptc datasets over the full focal plane, given the mixture of ITL and e2V CCDs.
Also, I've added a
countrate_per_pixeloption for flat images. This was extremely useful for creating PTC datasets during OR3/4, since one can control the signal level via the exposure times in an opsim db file. It will be needed for generating calibration datasets, e.g., for new sims using theLSSTCamSiminstrument.