Conversation
…th 1D ancillary data won't concatenate properly
… of which axis to add to 1D arrays
…eturn a float if `_pdf` should return only a single value, to fix an issue with the `entropy` function
eacharles
approved these changes
Jan 24, 2026
Collaborator
eacharles
left a comment
There was a problem hiding this comment.
I added some stuff to deal with the ppf of the spline, which had some numerical issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem & Solution Description (including issue #)
This fixes an issue I ran into that concatenating qp ensembles with 1D ancillary data didn't work.
ensure_2d_arrayfunction in dictionary.py to replacenp.atleast_2duse inconcatenate_dictsqp.concatentate, the concatenation of ancillary data is called with axis=0Code Quality
#pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added