-
Notifications
You must be signed in to change notification settings - Fork 1
Copier update: base image #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,3 +1,9 @@ | ||||||||||||
| # Questions specific to this template | ||||||||||||
|
|
||||||||||||
|
|
||||||||||||
|
|
||||||||||||
|
|
||||||||||||
|
|
||||||||||||
|
Comment on lines
+1
to
+6
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix excessive blank lines. Static analysis reports 5 blank lines where only 2 are allowed. Proposed fix # Questions specific to this template
-
-
-
-
-
+
+
# Questions managed by upstream template📝 Committable suggestion
Suggested change
🧰 Tools🪛 YAMLlint (1.38.0)[error] 6-6: too many blank lines (5 > 2) (empty-lines) 🤖 Prompt for AI Agents |
||||||||||||
| # Questions managed by upstream template | ||||||||||||
| repo_name: | ||||||||||||
| type: str | ||||||||||||
|
|
@@ -27,6 +33,11 @@ ssh_port_number: | |||||||||||
| # Pick a random port, but ensure it's not in the excluded port range on Windows (powershell: `netsh int ipv4 show excludedportrange protocol=tcp`) | ||||||||||||
| default: "{{ ( (range(49152, 49752) | list) + (range(49852, 50000) | list) + (range(50060, 50160) | list) + (range(50160, 50260) | list) + (range(50260, 50360) | list) + (range(50914, 51014) | list) + (range(51114, 51214) | list) + (range(51214, 51314) | list) + (range(51314, 51414) | list) + (range(51623, 51723) | list) + (range(51723, 51823) | list) + (range(65269, 65369) | list) + (range(65369, 65469) | list) ) | random }}" | ||||||||||||
|
|
||||||||||||
| pull_from_ecr: | ||||||||||||
| type: bool | ||||||||||||
| help: Will you need to pull images from a central AWS Elastic Container Registry? | ||||||||||||
| default: no | ||||||||||||
|
|
||||||||||||
| use_windows_in_ci: | ||||||||||||
| type: bool | ||||||||||||
| help: Should CI in the instantiated template also use Windows runners? | ||||||||||||
|
|
@@ -51,24 +62,24 @@ python_package_registry: | |||||||||||
| aws_identity_center_id: | ||||||||||||
| type: str | ||||||||||||
| help: What's the ID of your Organization's AWS Identity center, e.g. d-9145c20053? | ||||||||||||
| when: "{{ python_package_registry == 'AWS CodeArtifact' or install_aws_ssm_port_forwarding_plugin or True }}" | ||||||||||||
| when: "{{ python_package_registry == 'AWS CodeArtifact' or install_aws_ssm_port_forwarding_plugin or pull_from_ecr or True }}" | ||||||||||||
|
|
||||||||||||
| aws_org_home_region: | ||||||||||||
| type: str | ||||||||||||
| help: What is the home region of the AWS Organization (where all of the central infrastructure is deployed)? | ||||||||||||
| default: us-east-1 | ||||||||||||
| when: "{{ python_package_registry == 'AWS CodeArtifact' or install_aws_ssm_port_forwarding_plugin or True }}" | ||||||||||||
| when: "{{ python_package_registry == 'AWS CodeArtifact' or install_aws_ssm_port_forwarding_plugin or pull_from_ecr or True }}" | ||||||||||||
|
Comment on lines
+65
to
+71
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: git ls-files | grep -i copierRepository: LabAutomationAndScreening/copier-aws-central-infrastructure Length of output: 255 🏁 Script executed: cat -n copier.yml | sed -n '60,75p'Repository: LabAutomationAndScreening/copier-aws-central-infrastructure Length of output: 943 🏁 Script executed: rg 'or True' copier.ymlRepository: LabAutomationAndScreening/copier-aws-central-infrastructure Length of output: 364 🏁 Script executed: rg 'when:' copier.yml -A 1Repository: LabAutomationAndScreening/copier-aws-central-infrastructure Length of output: 1284 🏁 Script executed: rg 'or True' --type yamlRepository: LabAutomationAndScreening/copier-aws-central-infrastructure Length of output: 386 🏁 Script executed: rg 'python_package_registry|install_aws_ssm_port_forwarding_plugin|pull_from_ecr' copier.yml | head -20Repository: LabAutomationAndScreening/copier-aws-central-infrastructure Length of output: 566 The The 🤖 Prompt for AI Agents |
||||||||||||
|
|
||||||||||||
| aws_central_infrastructure_account_id: | ||||||||||||
| type: str | ||||||||||||
| help: What's the ID of your Organization's AWS Account containing Central Infrastructure (e.g. CodeArtifact)? | ||||||||||||
| when: "{{ python_package_registry == 'AWS CodeArtifact' }}" | ||||||||||||
| when: "{{ python_package_registry == 'AWS CodeArtifact' or pull_from_ecr }}" | ||||||||||||
| default: "000000000000" | ||||||||||||
|
|
||||||||||||
| core_infra_base_access_profile_name: | ||||||||||||
| type: str | ||||||||||||
| help: What's the AWS Identity Center Profile name for base access to the Central Infrastructure account (i.e. to read from CodeArtifact)? | ||||||||||||
| when: "{{ python_package_registry == 'AWS CodeArtifact' }}" | ||||||||||||
| when: "{{ python_package_registry == 'AWS CodeArtifact' or pull_from_ecr }}" | ||||||||||||
| default: CoreInfraBaseAccess | ||||||||||||
|
|
||||||||||||
|
|
||||||||||||
|
|
||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,22 @@ | ||
| # base image tags available at https://mcr.microsoft.com/v2/devcontainers/universal/tags/list | ||
| # added the platform flag to override any local settings since this image is only compatible with linux/amd64. since this image is only x64 compatible, suppressing the hadolint rule | ||
| # hadolint ignore=DL3029 | ||
| FROM --platform=linux/amd64 mcr.microsoft.com/devcontainers/universal:2.13.1-focal | ||
| FROM --platform=linux/amd64 mcr.microsoft.com/devcontainers/universal:5.1.1-noble | ||
|
|
||
| SHELL ["/bin/bash", "-o", "pipefail", "-c"] | ||
|
|
||
| # temporary hack until yarn updates its GPG key | ||
| RUN rm /etc/apt/sources.list.d/yarn.list || true | ||
|
Comment on lines
+8
to
+9
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial Consider tracking the temporary workaround. The yarn GPG key workaround is appropriately marked as temporary. The Would you like me to open an issue to track removal of this workaround once yarn updates its GPG key? 🤖 Prompt for AI Agents |
||
|
|
||
| RUN apt-get update -y && apt-get install -y \ | ||
| "bash-completion=$(apt-cache madison bash-completion | awk '{print $3}' | grep '^1:2.10' | head -n 1)" --no-install-recommends \ | ||
| "bash-completion=$(apt-cache madison bash-completion | awk '{print $3}' | grep '^1:2.11' | head -n 1)" --no-install-recommends \ | ||
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # Create the venv folder and set permissions for anyone to modify---this is necessary to be able to break out the venv folder as a separate docker volume for better performance on Windows hosts | ||
| ARG REPO_NAME=copier-base-template | ||
| ENV VENV_PATH=/workspaces/${REPO_NAME}/.venv | ||
| RUN mkdir -p /workspace && \ | ||
| RUN mkdir -p /workspaces && \ | ||
| mkdir -p ${VENV_PATH} && \ | ||
| chmod -R 777 /workspaces ${VENV_PATH} && \ | ||
| chgrp -R 0 /workspaces ${VENV_PATH} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
actions/cache v5.0.2 release notes breaking changes💡 Result:
For
actions/cache@v5.0.2, the release notes list one behavior change (and no explicitly labeled “breaking changes”):The breaking changes are at the
v5major line level (apply tov5.0.2as well):actions/cache@v5runs on Node.js 24. [2]Sources: [1] [2]
Review actions/cache v5.0.2 upgrade for operational concerns.
The upgrade to
v5.0.2introduces a behavior change: HTTP 429 throttling responses will no longer be retried when creating cache entries, increasing the chance of cache-save failures under rate limiting. Additionally, this version requires Node.js 24 runtime and GitHub Actions Runner >= 2.327.1, which may affect self-hosted runner compatibility. Confirm these changes align with your CI/CD infrastructure requirements.🤖 Prompt for AI Agents