Skip to content

Fix create API key test #1970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

Fix create API key test #1970

merged 1 commit into from
Apr 16, 2025

Conversation

paulnoirel
Copy link
Contributor

@paulnoirel paulnoirel commented Apr 15, 2025

Description

Skip test test_create_api_key_insufficient_permissions if the current account is an admin.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@paulnoirel paulnoirel changed the title Fix create API key test and Mask geometry Fix create API key test Apr 15, 2025
@paulnoirel paulnoirel force-pushed the pno/PLT-0-fix-sdk-tests branch from 49e2879 to 0b9f31e Compare April 15, 2025 23:41
@paulnoirel paulnoirel force-pushed the pno/PLT-0-fix-sdk-tests branch from 86c7bad to b9bbca0 Compare April 15, 2025 23:45
Copy link
Contributor

@paultancre paultancre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@paulnoirel paulnoirel requested a review from paultancre April 16, 2025 17:05
Copy link

@john-labelbox john-labelbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulnoirel paulnoirel merged commit 08bef72 into develop Apr 16, 2025
16 of 27 checks passed
@paulnoirel paulnoirel deleted the pno/PLT-0-fix-sdk-tests branch April 16, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants