Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
There was a problem hiding this comment.
Pull request overview
This PR adds a new QSmallFaceExtra protobuf message to the v2 message proto file, mirroring the existing definition in proto/message/v1/element.proto. The message provides fields for representing small face (emoji) data including a face_id and two preview strings.
Changes:
- Added
QSmallFaceExtramessage with three fields (face_id,preview,preview2) to the v2 proto, positioned betweenFaceExtraandQFaceExtra.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| optional uint32 face_id = 1; | ||
| optional string preview = 2; | ||
| optional string preview2 = 3; |
There was a problem hiding this comment.
The v2 proto file uses proto2 syntax (line 1), which requires every field to have an explicit label (optional, required, or repeated). All other messages in this file consistently use optional for scalar fields (e.g., FaceExtra at line 597, QFaceExtra at lines 607–616). The three fields here are missing the optional label, which makes them invalid proto2 and inconsistent with the rest of the file.
It looks like these fields were copied verbatim from proto/message/v1/element.proto (which uses proto3 syntax where labels are implicit). Please add optional to all three fields to match the v2 file conventions.
No description provided.