Added explicit way to forward self app name to Ragger/Speculos if it is not readable in the elf file #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for explicitly specifying the application name when it cannot be read from the ELF file, particularly useful for Rust applications in swap tests using the modern test framework.
- Added a new optional configuration parameter
SELF_APP_NAMEto explicitly set the library name - Modified the Speculos argument preparation logic to prepend the custom app name to the library path when configured
- Updated the changelog to document this new feature
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/ragger/conftest/configuration.py | Added SELF_APP_NAME optional configuration parameter to the OptionalOptions dataclass with a default value of None |
| src/ragger/conftest/base_conftest.py | Updated prepare_speculos_args to use SELF_APP_NAME when building the library load argument for Speculos |
| CHANGELOG.md | Documented the new feature in version 1.42.0 release notes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #263 +/- ##
==========================================
- Coverage 77.94% 77.94% -0.01%
==========================================
Files 36 36
Lines 2145 2149 +4
==========================================
+ Hits 1672 1675 +3
- Misses 473 474 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fbeutin-ledger
force-pushed
the
fbe/add_self_app_name
branch
from
fc82f31 to
7649dda
Compare
…is not readable in the elf file
fbeutin-ledger
force-pushed
the
fbe/add_self_app_name
branch
from
7649dda to
d7c2aaf
Compare
|
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used notably but the swap tests of rust applications on modern test framework