Implemented Controls, and Screen. Also cleaned up Sound class.#5
Open
DeepWolf413 wants to merge 4 commits intoLemonUIbyLemon:masterfrom
Open
Implemented Controls, and Screen. Also cleaned up Sound class.#5DeepWolf413 wants to merge 4 commits intoLemonUIbyLemon:masterfrom
DeepWolf413 wants to merge 4 commits intoLemonUIbyLemon:masterfrom
Conversation
I changed the string parameters for SetFile, SetSet, and the constructor to 'const std::string&' so it is being sent as a reference instead. Before the changes it would make a copy of the string being sent as an argument. And the const basically marks it as not being changed in the scope of the function/constructor.
I also removed Screen from the namespace to keep things consistent with the rest of the project (other cpp files currently only has LemonUI in the namespace).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.