Skip to content

fix(bank-transfer): rename MULTI_TENANT_INFRA_ENABLED to MULTI_TENANT_ENABLED for consistency#1176

Merged
guimoreirar merged 1 commit intodevelopfrom
chore/add-bank-transfer-config
Apr 8, 2026
Merged

fix(bank-transfer): rename MULTI_TENANT_INFRA_ENABLED to MULTI_TENANT_ENABLED for consistency#1176
guimoreirar merged 1 commit intodevelopfrom
chore/add-bank-transfer-config

Conversation

@guimoreirar
Copy link
Copy Markdown
Member

  • Updated configuration in values-template.yaml and values.yaml to reflect the new naming convention.
  • Adjusted configmap.yaml to ensure proper handling of the renamed variable.

Midaz Pull Request Checklist

Pull Request Type

  • Midaz
  • Plugin Access Manager
  • Plugin CRM
  • Reporter
  • Plugin Fees
  • Plugin BR PIX Direct JD
  • Plugin BR PIX Indirect BTG
  • Otel Collector
  • Pipeline
  • Documentation
  • Fetcher
  • Matcher
  • Flowker
  • Underwriter

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

Obs: Please, always remember to target your PR to develop branch instead of main.

…_ENABLED for consistency

- Updated configuration in values-template.yaml and values.yaml to reflect the new naming convention.
- Adjusted configmap.yaml to ensure proper handling of the renamed variable.
@guimoreirar guimoreirar self-assigned this Apr 8, 2026
@guimoreirar guimoreirar requested a review from a team as a code owner April 8, 2026 19:59
@guimoreirar guimoreirar merged commit b345058 into develop Apr 8, 2026
1 of 3 checks passed
@guimoreirar guimoreirar deleted the chore/add-bank-transfer-config branch April 8, 2026 19:59
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 532ad3c0-a43b-4dcc-91eb-07842e57d981

📥 Commits

Reviewing files that changed from the base of the PR and between 5ab7e19 and 0fb14a6.

📒 Files selected for processing (3)
  • charts/plugin-br-bank-transfer/templates/configmap.yaml
  • charts/plugin-br-bank-transfer/values-template.yaml
  • charts/plugin-br-bank-transfer/values.yaml

Walkthrough

The Helm chart for the Brazilian bank transfer plugin updates its multi-tenancy configuration. The configuration key MULTI_TENANT_INFRA_ENABLED is renamed to MULTI_TENANT_ENABLED across values files, and the ConfigMap template is refactored to use a single conditional block wrapping all multi-tenant environment variables.

Changes

Cohort / File(s) Summary
Multi-tenancy Configuration Updates
charts/plugin-br-bank-transfer/templates/configmap.yaml, charts/plugin-br-bank-transfer/values.yaml, charts/plugin-br-bank-transfer/values-template.yaml
Renamed configuration key from MULTI_TENANT_INFRA_ENABLED to MULTI_TENANT_ENABLED. Refactored ConfigMap template to replace three separate conditional blocks with a single encompassing conditional block that wraps all multi-tenant environment variables (MULTI_TENANT_URL, AWS_REGION, MULTI_TENANT_REDIS_HOST), now emitting them with default empty strings when enabled instead of only when values are non-empty.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant