LC-2848 ADMIN 프로그램 관리 가이드북 등록 버튼 추가 및 목록 UI 구현#2139
Hidden character warning
LC-2848 ADMIN 프로그램 관리 가이드북 등록 버튼 추가 및 목록 UI 구현#2139yeji424 wants to merge 1 commit intoLC-2838-Sprint-17from
Conversation
Summary of ChangesHello @yeji424, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 가이드북 관리와 관련된 프론트엔드 로직을 업데이트된 백엔드 API 스키마 및 어드민 로직 스펙에 맞춰 동기화합니다. 이를 통해 데이터 일관성을 확보하고, 가이드북 생성, 수정, 조회 기능이 올바르게 작동하도록 보장하며, 사용자 인터페이스가 최신 데이터 구조를 정확하게 반영하도록 합니다. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
| id: 0, | ||
| title: '가이드북 제목', | ||
| desc: '가이드북 설명', | ||
| shortDesc: '가이드북 짧은 설명', | ||
| thumbnail: null, | ||
| desktopThumbnail: null, | ||
| contentStructure: '자료 구성 내용', | ||
| contentComposition: '자료 구성 내용', | ||
| accessMethod: '가이드북 열람 방식', | ||
| recommendedFor: '가이드북 추천 대상', | ||
| priceInfo: { | ||
| priceId: 1, | ||
| price: 10000, | ||
| discount: 1000, | ||
| guidebookPriceType: 'CHARGE', | ||
| }, | ||
| description: '가이드북 설명', | ||
| isVisible: true, | ||
| job: null, | ||
| contentUrl: null, | ||
| contentFileUrl: null, | ||
| price: 10000, | ||
| discount: 1000, |
There was a problem hiding this comment.
Mock 데이터에서 사용된 ID(0), 가격(10000) 및 할인 금액(1000)과 같은 숫자는 의미를 명확히 하고 유지보수성을 높이기 위해 명명된 상수로 대체하는 것이 좋습니다.
References
- 의미가 불분명한 매직 넘버를 명명된 상수로 대체하여 가독성을 높여야 합니다. (link)
| title: z.string(), | ||
| desc: z.string().nullable().optional(), | ||
| id: z.number(), | ||
| title: z.string().nullable().optional(), |
| accountType?: AccountType; | ||
| }; | ||
| guidebookPriceType: GuidebookPriceType; | ||
| guidebookPriceType?: GuidebookPriceType; |
There was a problem hiding this comment.
연관 작업