Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
berry-13
force-pushed
the
refactor/chat-composer-tray
branch
from
November 5, 2026 21:36
348c619 to
be2131e
Compare
berry-13
force-pushed
the
refactor/chat-composer-tray
branch
from
November 6, 2026 16:37
be2131e to
4cfbdf2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The composer's staged-context tray (file cards first, then the quote and manual-skill chips) and
useComposerItems, the hook that merges the staged quotes and skills into one ordered list, still live in the app. A consumer of@librechat/chatcould not show what is staged for the next send.This PR moves the tray to
packages/chat/src/components/composer/Tray.tsx, exported asComposerTray, and the hook topackages/chat/src/react/items.ts, exported from@librechat/chat/react. The tray no longer reaches into the app for uploads: it takesabortUploadas a prop, and the client'sComposer/Tray.tsxshrinks to a wrapper that supplies it fromuseFileHandlingNoChatContext, soChatFormkeeps its import. Rendering and behavior are unchanged, including the focus hand-off after a quote is dismissed.Stacked on #17801.
Type of change
Testing
Tested environments/configuration:
Automated tests:
Tray.spec.tsxanduseComposerItems.spec.tsxmoved intopackages/chatand run against the English bundle (the mocked keys became copy such asRemove quoteandStaged context). The tray spec drops its mock of the app's translation hook and gains a case thatabortUploadreaches the file row.Chat/Input,ChatView,hooks/Input): 49 suites, 1108 tests.npx tsc --noEmitin packages/chat and client: clean. ESLint, Prettier and the import sorter on touched files: clean.staged-quotes-show-as-chips-and-remove-onescenario covers the rendered tray in CI.Screenshots / recordings
No user-facing change. The tray's markup and classes are unchanged.
Risk / compatibility
useComposerItemsnow reads its atoms from the package's own composer state, the same atoms the client already imported from@librechat/chat/react.Checklist