Ignore/skip invalid objects #889
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #889 +/- ##
=======================================
Coverage 73.77% 73.77%
=======================================
Files 2 2
Lines 122 122
=======================================
Hits 90 90
Misses 32 32 ☔ View full report in Codecov by Sentry. |
|
I think this feature should be selectable at run-time, via some cmdline flag. Not compile-time. |
|
I"ll redo that for 0.13.2, with a run-time flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have to handle many DXF that just gave error 0x800.
This PR adds a warning with line number if a DXF object/entity fails to parse.
It skips the rest of the object/entity and continues parsing rather than terminating.
Often the culprit is some exotic structure that I don't care about.
This PR gives me a way of logging (many cloud uploads) what went wrong, judge the severity and improve the code so it does parse.
It now does this by default, because IMHO that's what is expected, but a compile flag can be set to revert ot the old behavior (with improved warning).
The encode and out_** files ignore the invalid objects/entities as well, so a result can be produced.