Skip to content

LIB-149 Drag & Dropping existing books in doesn't show issue popup #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brunoqueiroz1984 wants to merge 2 commits into
base: dev/develop
Choose a base branch
from
Open

LIB-149 Drag & Dropping existing books in doesn't show issue popup #170

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cae159
Update MHomePage.qml
brunoqueiroz1984 Apr 11, 2024
f64cbe7
Merge branch 'dev/develop' into bug/lib-149-existingBook
brunoqueiroz1984 Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/presentation/desktop/homePage/MHomePage.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,14 +862,14 @@ Page {
// it interrupts the adding and shows a popup. After the popup is closed, the
// adding is resumed by calling continueAddingBooks().
function addBooks(container) {
internal.booksCurrentlyAdding = container
for (var i = container.length - 1; i >= 0; i--) {
internal.lastAddedBookPath = container[i]
internal.booksCurrentlyAdding = [...container]
for (var i = internal.booksCurrentlyAdding.length - 1; i >= 0; i--) {
internal.lastAddedBookPath = internal.booksCurrentlyAdding[i]
let result = LibraryController.addBook(
internal.lastAddedBookPath)

// Remove the already added book
container.splice(i, 1)
internal.booksCurrentlyAdding.splice(i, 1)

if (result === BookOperationStatus.OpeningBookFailed) {
unsupportedFilePopup.open()
Expand Down