migrate rules_cc dependency to MOUDULE.bazel #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Light-City,
I want to thank you for creating and maintaining this amazing project! I am a beginner in C++, and I am using this project as a way to practice and learn more.
However, I ran into an issue while following your tutorial video on Bilibili, and I believe it might be due to recent updates to Bazel. Specifically, it seems that the contents of the
WORKSPACEfile have been moved toMODULE.bazelin newer versions of Bazel. As a result, I encountered an error related to missing therules_ccdependency when trying to run the project with Bazel.I found that in order to resolve this issue, I needed to add the
rules_ccdependency to theMODULE.bazelfile. I'm not completely sure about the purpose ofMODULE.bazel.lock, but I believe it might be auto-generated and related to managing dependencies.For reference, here is the information about my system:
This is my first pull request, and I hope this change will be helpful for you and other learners who may encounter the same issue. I'm not sure if my changes are correct, but you can just take it as a reminder.
Thank you again for your hard work on this project!