Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a custom parser class when using LightningCLI #20596

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mauvilsa
Copy link
Contributor

@mauvilsa mauvilsa commented Feb 19, 2025

What does this PR do?

Recently jsonargparse added new possibilities by customizing the argument parser class, for example:

However, currently LightningCLI doesn't allow changing the parser class to use. This pull request makes that possible.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20596.org.readthedocs.build/en/20596/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Feb 19, 2025
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79%. Comparing base (b313cd9) to head (bdc917e).

❗ There is a different number of reports uploaded between BASE (b313cd9) and HEAD (bdc917e). Click for more details.

HEAD has 314 uploads less than BASE
Flag BASE (b313cd9) HEAD (bdc917e)
cpu 95 24
lightning 73 18
pytest 49 0
python3.9 24 6
lightning_fabric 12 0
python3.11 24 6
python3.10 12 3
python3.12.7 35 9
gpu 2 0
pytorch2.1 18 9
pytest-full 48 24
pytorch2.2.2 6 3
pytorch_lightning 12 6
pytorch2.3 6 3
pytorch2.5.1 12 6
pytorch2.4.1 6 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #20596     +/-   ##
=========================================
- Coverage      88%      79%     -9%     
=========================================
  Files         267      264      -3     
  Lines       23369    23315     -54     
=========================================
- Hits        20478    18367   -2111     
- Misses       2891     4948   +2057     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant