-
Notifications
You must be signed in to change notification settings - Fork 83
Windows support #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2.4-stable
Are you sure you want to change the base?
Windows support #510
Conversation
bafbd71
to
07a2da6
Compare
Author: Author Name [email protected]
I would like to notify this comment in advance before this PR goes to compilable... I know you are working so hard on this PR and also I know you want to support windows again in the IBM storage archive product. But I must strongly disagree to this PR. Because this PR has no benefit to the normal open source users who are using the code in this repository. On the other hand code change is big and impact of the readability of codes are really big. I have so many comments and complains but top-3 of my comments are First, please don't introduce Second, please don't use For example, Last, please write macros to keep the C language context. I believe macro feature can easily ruins the C language context and create new your own langage. But this project is clearly written by C please do not corrupt the readability for C developers. I strongly recommend that you need to use inline function as much possible, that is a reason taht we choose C99. For example, this macro call confuses C developers in short period. They don't think
|
Summary of changes
This pull request includes following changes or fixes.
Description
Code was updated to be compatible again with Windows platform. Microsoft mandates compilation with Microsoft tools to give support, with that said the code needed to be compatible with Microsoft Visual C++ Compiler for a new version to be built.
Macros we're added to comply with this and change the behavior depending on which platform the project is being built.
Type of change
Checklist: