Lf 3068 when hiding point locations on farm map and zooming out clusters of 0 are shown #3993
+36
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… maxZoom changes - on login and on add new point location
…ap with event listener removal
Duncan-Brain
commented
Jan 8, 2026
| const [gMap, setGMap] = useState(null); | ||
| const [gMaps, setGMaps] = useState(null); | ||
| const [gMapBounds, setGMapBounds] = useState(null); | ||
| // Unused: Kept in for map debugging |
Collaborator
Author
There was a problem hiding this comment.
Wasn't sure about this.
Duncan-Brain
commented
Jan 8, 2026
| setShowSuccessHeader(false); | ||
| }; | ||
|
|
||
| useEffect(() => { |
Collaborator
Author
There was a problem hiding this comment.
Calling drawAssets twice redraws the cluster twice. MaxZoom triggers this on login (moving from undefined to defined and adding a new point with a different maxZoom values (ocean is easiest) .
Duncan-Brain
commented
Jan 8, 2026
| maxZoom, | ||
| ) => { | ||
| // If clusterer is being replaced, remove the old one from the map and cleanup listeners | ||
| if (clustererRef?.current) { |
Collaborator
Author
There was a problem hiding this comment.
If drawAssets() is ever called twice two clusters will be on the map. One would be responsive to filtering, and the other would not be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In addition to this old bug whose status is released. This also resolves a bug I saw this week where the upon login the point filters on map would appear not to work with clustered points. On refresh that bug would resolve.
This branch fixes the issue twice and does two things:
markerClusterRef.currentto anew MarkerCluster()it first removes the older cluster from the map, and cleans up any listeners before setting the new one. Previously it assumes thatmarkerClusterRef.currentwas yet to be definedLocationPickerJira link: LF-3068
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
In addition to what is outline on the Jira ticket:
Logout method
a. logout and login to farm with clustered points
b. navigate to map and filter that cluster
c. observe number remains the same but zooming in shows items are correctly filtered
d. refresh map, problem does not persist
Add point location method
a. add a new point location to an area that will cause a maxZoom difference (ocean is easiest)
b. filter the cluster
c. observe the number remains the same but zooming in shows items correctly filtered
d. refresh on map, problem does not persist
Checklist:
pnpm i18nto help with this)