Skip to content

LF-4779 - Repair Chromatic GitHub action workflow#4231

Merged
kathyavini merged 2 commits into
integrationfrom
chore/atrevino/LF-4779-chromatic-run-fix
Jun 30, 2026
Merged

LF-4779 - Repair Chromatic GitHub action workflow#4231
kathyavini merged 2 commits into
integrationfrom
chore/atrevino/LF-4779-chromatic-run-fix

Conversation

@atrevino89

@atrevino89 atrevino89 commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR fixes the Chromatic deployment workflow from GH Actions, I also added a small fix in one of the stories (if that's the correct name) in order to see the whole workflow run green... perhaps this last thing is not the way it should be addressed therefore it would be ok to disregard it from the PR and fix it in another PR properly.
I updated some actions versions too to avoid warnings related to old node usage.

Jira link: https://lite-farm.atlassian.net/browse/LF-4779

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Passing workflow:
https://github.com/LiteFarmOrg/LiteFarm/actions/runs/28401037350

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other - GHA workflow

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have ordered translation keys alphabetically (optional: run pnpm i18n to help with this)
  • I have added the GNU General Public License to all new files

@atrevino89 atrevino89 requested review from a team as code owners June 29, 2026 20:44
@atrevino89 atrevino89 requested review from SayakaOno and kathyavini and removed request for a team June 29, 2026 20:44

@kathyavini kathyavini left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!!! This has been failing for so long I don't know if I've ever even seen what it looks like when Chromatic catches a regression. I can't wait!!! 😁 Fantastic!

Comment thread .github/workflows/chromatic.yml Outdated
run: ./node_modules/.bin/chromatic --project-token ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
run: pnpm install --frozen-lockfile
- name: Run Chromatic
uses: chromaui/action@latest

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May we pin this version, just to safe? It has failed so long I don't want it to regress again with package update 😂

Either @17 or even the SHA from the passing workflow would be great!

chromaui/action@98132da0fca2211fb41b3af7b49ce85176007851 # v17.8.0

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@atrevino89 atrevino89 force-pushed the chore/atrevino/LF-4779-chromatic-run-fix branch from dd30f3e to a32d138 Compare June 30, 2026 01:12
@atrevino89 atrevino89 force-pushed the chore/atrevino/LF-4779-chromatic-run-fix branch from a32d138 to e5a4723 Compare June 30, 2026 01:18
@atrevino89 atrevino89 requested a review from kathyavini June 30, 2026 01:22

@kathyavini kathyavini left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! ❤️‍🔥

@kathyavini kathyavini added this pull request to the merge queue Jun 30, 2026
Merged via the queue into integration with commit 3bc7358 Jun 30, 2026
10 checks passed
@atrevino89 atrevino89 deleted the chore/atrevino/LF-4779-chromatic-run-fix branch June 30, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants