Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commands: fix prep commands when empty #1083

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Mar 27, 2023

Description

Fixes an issue introduced by #977 when the global_prep_cmd config option was not set in the config file.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher
Copy link
Member Author

@pgrunzjr we found a small bug in your PR. Feel free to review this fix. If you have a better idea on how to fix it, I'm open to suggestions. Thanks!

@ReenigneArcher ReenigneArcher force-pushed the fix-prep-commands-when-empty branch from 910915a to d6de09b Compare March 27, 2023 19:32
@ReenigneArcher ReenigneArcher force-pushed the fix-prep-commands-when-empty branch from d6de09b to b845134 Compare March 27, 2023 19:56
@ReenigneArcher ReenigneArcher merged commit 014ca7e into nightly Mar 27, 2023
@ReenigneArcher ReenigneArcher deleted the fix-prep-commands-when-empty branch March 27, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants