Use Share button on DS4 controllers (ViGEm DS4_BUTTON_SHARE) as BACK action #1151
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is currently not possible to register a "BACK" action (Select / Share button press) when Sunshine is configured to emulate a DS4 controller on Windows.
This seems to be due to the BACK action being triggered by the touchpad button press instead.
When testing I was not able to register a BACK action using the touchpad, since as soon as the touchpad is pressed it is treated as a mouse input instead.
This PR is a simple fix for the "BACK" functionality on DS4 controller emulation when using a DS4 or DualSense controller, which maps it to the Share button, and unmaps the non-functional touchpad press.
(It is up to interpretation whether this is a breaking change, as it unmaps the touchpad press despite the touchpad press seemingly being incorrectly registered.)
Screenshot
N/A
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.