Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Share button on DS4 controllers (ViGEm DS4_BUTTON_SHARE) as BACK action #1151

Merged

Conversation

aseligmann
Copy link
Contributor

Description

It is currently not possible to register a "BACK" action (Select / Share button press) when Sunshine is configured to emulate a DS4 controller on Windows.
This seems to be due to the BACK action being triggered by the touchpad button press instead.
When testing I was not able to register a BACK action using the touchpad, since as soon as the touchpad is pressed it is treated as a mouse input instead.

This PR is a simple fix for the "BACK" functionality on DS4 controller emulation when using a DS4 or DualSense controller, which maps it to the Share button, and unmaps the non-functional touchpad press.

(It is up to interpretation whether this is a breaking change, as it unmaps the touchpad press despite the touchpad press seemingly being incorrectly registered.)

Screenshot

N/A

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@CLAassistant
Copy link

CLAassistant commented Apr 7, 2023

CLA assistant check
All committers have signed the CLA.

@aseligmann aseligmann changed the title Use DS4_BUTTON_SHARE as BACK action Use Share button on DS4 controllers (ViGEm DS4_BUTTON_SHARE) as BACK action Apr 7, 2023
@cgutman cgutman force-pushed the fix/ds4_share_button_as_back branch from 3e35e0e to 9c02aa3 Compare April 8, 2023 20:36
@cgutman cgutman merged commit 0e92bdd into LizardByte:nightly Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants