Implement new protocol extension to match client connections together #1945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces support for the
X-SS-Connect-Data
andX-SS-Ping-Payload
extension that allows Moonlight to provide identifiers with its ENet connect message and A/V ping packets respectively. This allows Sunshine to correctly correlate those connections with an active session even if they are coming from different IP addresses (which can often happen due to Carrier-Grade NAT).These extensions require new Moonlight clients that contain the latest moonlight-common-c code, otherwise it will fall back to the older codepaths.
Associated Moonlight commits:
moonlight-stream/moonlight-common-c@dc18608
moonlight-stream/moonlight-common-c@6e9ed87
Screenshot
Issues Fixed or Closed
Fixes #1804
Fixes #1862
Fixes #1852
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.