Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install ViGEmBus before starting Sunshine #2183

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Feb 27, 2024

Description

Since #1948, we display a fatal log message in the UI if ViGEmBus is unavailable. This is good to help users debug their gamepad issues, but it incorrectly triggers on a clean system when Sunshine is first installed. The problem is that we are starting Sunshine before we install ViGEmBus, so the first initialization happens without ViGEmBus and triggers the warning. Switching the order of operations in the installer should avoid the warning.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@cgutman cgutman added this to the 0.22.0 milestone Feb 27, 2024
@cgutman cgutman force-pushed the install_vigembus_first branch from eac2c66 to a97720f Compare February 28, 2024 03:21
@cgutman cgutman merged commit 1020d0c into LizardByte:nightly Feb 28, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants