Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): list available displays with select #2490

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

chore: fix denominator

b03b874
Select commit
Loading
Failed to load commit list.
Draft

feat(ui): list available displays with select #2490

chore: fix denominator
b03b874
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 3, 2025 in 0s

8.18% (+1.19%) compared to 4b6ff37

View this Pull Request on Codecov

8.18% (+1.19%) compared to 4b6ff37

Details

Codecov Report

Attention: Patch coverage is 0% with 54 lines in your changes missing coverage. Please review.

Project coverage is 8.18%. Comparing base (4b6ff37) to head (b03b874).
Report is 330 commits behind head on master.

Files with missing lines Patch % Lines
src/platform/macos/display_options.mm 0.00% 36 Missing ⚠️
src/confighttp.cpp 0.00% 11 Missing and 1 partial ⚠️
src/display_device/dd.h 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #2490      +/-   ##
=========================================
+ Coverage    6.99%   8.18%   +1.19%     
=========================================
  Files          87      49      -38     
  Lines       17679    8181    -9498     
  Branches     8399    3818    -4581     
=========================================
- Hits         1237     670     -567     
+ Misses      13745    7125    -6620     
+ Partials     2697     386    -2311     
Files with missing lines Coverage Δ
src/config.h 0.00% <ø> (ø)
src/platform/common.h 55.26% <ø> (+24.01%) ⬆️
src/display_device/dd.h 0.00% <0.00%> (ø)
src/confighttp.cpp 0.65% <0.00%> (-0.19%) ⬇️
src/platform/macos/display_options.mm 0.00% <0.00%> (ø)

... and 72 files with indirect coverage changes