Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(cmake): fix typo in publisher name variable #3158

Merged

Conversation

ReenigneArcher
Copy link
Member

Description

Fix small typo.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher marked this pull request as draft September 9, 2024 13:27
@ReenigneArcher
Copy link
Member Author

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.70%. Comparing base (8c218b5) to head (d0eb250).
Report is 99 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3158      +/-   ##
=========================================
- Coverage    9.83%   9.70%   -0.13%     
=========================================
  Files         101      77      -24     
  Lines       17990   14074    -3916     
  Branches     8411    6460    -1951     
=========================================
- Hits         1769    1366     -403     
+ Misses      13336   10088    -3248     
+ Partials     2885    2620     -265     
Flag Coverage Δ
Linux ?
Windows 5.06% <ø> (ø)
macOS-12 10.78% <ø> (ø)
macOS-13 10.67% <ø> (ø)
macOS-14 10.97% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 56 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the build/arch/fix-typo-in-publisher-name-variable branch from 727e2a1 to d0eb250 Compare September 9, 2024 22:55
@ReenigneArcher ReenigneArcher changed the title build(arch): fix typo in publisher name variable build(cmake): fix typo in publisher name variable Sep 9, 2024
@ReenigneArcher ReenigneArcher marked this pull request as ready for review September 9, 2024 22:55
Copy link

sonarqubecloud bot commented Sep 9, 2024

@ReenigneArcher ReenigneArcher merged commit 330ab76 into master Sep 9, 2024
37 of 38 checks passed
@ReenigneArcher ReenigneArcher deleted the build/arch/fix-typo-in-publisher-name-variable branch September 9, 2024 23:44
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant