Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(script): fix missing sudo for dnf group install #3227

Merged

Conversation

ReenigneArcher
Copy link
Member

Description

dnf group install command was missing sudo.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.84%. Comparing base (1071f13) to head (d1350bb).
Report is 98 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #3227   +/-   ##
======================================
  Coverage    9.84%   9.84%           
======================================
  Files         101     101           
  Lines       17974   17974           
  Branches     8402    8402           
======================================
  Hits         1770    1770           
- Misses      13319   13324    +5     
+ Partials     2885    2880    -5     
Flag Coverage Δ
Linux 7.27% <ø> (ø)
Windows 5.07% <ø> (ø)
macOS-12 10.81% <ø> (+0.02%) ⬆️
macOS-13 10.70% <ø> (-0.02%) ⬇️
macOS-14 10.00% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@ReenigneArcher ReenigneArcher added this to the stable release milestone Sep 28, 2024
@ReenigneArcher ReenigneArcher force-pushed the build/script/fix-missing-sudo-for-dnf-group-install branch from 7745bf4 to d1350bb Compare September 28, 2024 18:25
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) September 28, 2024 18:25
Copy link

@ReenigneArcher ReenigneArcher merged commit b01ba38 into master Sep 28, 2024
38 checks passed
@ReenigneArcher ReenigneArcher deleted the build/script/fix-missing-sudo-for-dnf-group-install branch September 28, 2024 19:02
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant