Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix image paths #346

Merged
merged 5 commits into from
Oct 16, 2022
Merged

fix image paths #346

merged 5 commits into from
Oct 16, 2022

Conversation

ReenigneArcher
Copy link
Member

Description

Fix issue where Sunshine assumes image is relative to current working directory.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher force-pushed the fix/image-paths branch 2 times, most recently from 64a4882 to b7f1233 Compare August 26, 2022 23:24
@ReenigneArcher ReenigneArcher marked this pull request as ready for review September 12, 2022 00:36
@ReenigneArcher
Copy link
Member Author

ReenigneArcher commented Sep 12, 2022

Todo:

  • test linux deb/rpm
  • test linux appimage
  • test linux flatpak
  • test macos
  • test windows

@ReenigneArcher ReenigneArcher force-pushed the fix/image-paths branch 4 times, most recently from 1eaa85f to e738ec9 Compare October 15, 2022 23:48
@ReenigneArcher ReenigneArcher merged commit 09c9a1a into nightly Oct 16, 2022
@ReenigneArcher ReenigneArcher deleted the fix/image-paths branch October 16, 2022 13:33
@ReenigneArcher ReenigneArcher mentioned this pull request Oct 16, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant