Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(cmake): check for MinHook during configure #3533

Merged

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Jan 14, 2025

Description

This PR will check for MinHook during cmake configure step instead of failing during the build step.

PLATFORM_LIBRARIES is also listed alphabetically.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher added this to the stable release milestone Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.30%. Comparing base (820180c) to head (a0cafc3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #3533     +/-   ##
=========================================
  Coverage   10.30%   10.30%             
=========================================
  Files          90       90             
  Lines       16130    16130             
  Branches     7655     7655             
=========================================
  Hits         1662     1662             
- Misses      11918    13911   +1993     
+ Partials     2550      557   -1993     
Flag Coverage Δ
Linux 9.68% <ø> (ø)
Windows 10.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 33 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the build(cmake)-check-for-MinHook-during-configure branch from 6a6b94b to a0cafc3 Compare January 14, 2025 22:24
@ReenigneArcher ReenigneArcher marked this pull request as ready for review January 14, 2025 22:25
@ReenigneArcher ReenigneArcher merged commit 53b9be1 into master Jan 15, 2025
37 checks passed
@ReenigneArcher ReenigneArcher deleted the build(cmake)-check-for-MinHook-during-configure branch January 15, 2025 13:25
@Snarfster
Copy link

@ReenigneArcher This merge broke the windows installer build on my end. The MinHook.dll was missing when trying to run sunshine.exe if I am recalling correctly.

@ReenigneArcher
Copy link
Member Author

Thanks. We're already aware of the issue and will have a fix out soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants