Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(display): expose HDR toggle workaround delay to user #3579

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

FrogTheFrog
Copy link
Collaborator

Description

Expose the HDR toggle workaround delay to user in case the previously used 500ms is too much or too little.

Screenshot

New configurable value instead of checkbox:
image

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 11.61%. Comparing base (9aaa40c) to head (f8ae0e1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/config.cpp 0.00% 1 Missing and 2 partials ⚠️
src/display_device.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3579      +/-   ##
==========================================
- Coverage   13.01%   11.61%   -1.41%     
==========================================
  Files          66       92      +26     
  Lines       12338    17337    +4999     
  Branches     5653     8100    +2447     
==========================================
+ Hits         1606     2013     +407     
- Misses      10334    12833    +2499     
- Partials      398     2491    +2093     
Flag Coverage Δ
Linux 11.28% <0.00%> (?)
Windows 13.01% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/config.h 0.00% <ø> (ø)
src/display_device.cpp 54.94% <0.00%> (-0.03%) ⬇️
src/config.cpp 0.00% <0.00%> (ø)

... and 56 files with indirect coverage changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • src/config.cpp: Language not supported
  • src/config.h: Language not supported
  • src/display_device.cpp: Language not supported
  • src_assets/common/assets/web/config.html: Language not supported
  • src_assets/common/assets/web/public/assets/locale/en.json: Language not supported
Comments suppressed due to low confidence (1)

src_assets/common/assets/web/configs/tabs/audiovideo/DisplayDeviceOptions.vue:137

  • Ensure that the new HDR toggle delay input field is covered by tests to verify the delay functionality works as expected.
<input type="number" class="form-control" id="dd_wa_hdr_toggle_delay" placeholder="0" min="0" max="3000" v-model="config.dd_wa_hdr_toggle_delay" />
@ReenigneArcher ReenigneArcher merged commit fa22227 into LizardByte:master Feb 18, 2025
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants