feat(linux/xdgportal): Add support for pipewire-serial#5060
Conversation
|
Let's leave this as a draft for now until the changes are merged to/available on xdg-desktop-portal and this can be properly tested. |
d04bca7 to
a9e9764
Compare
|
|
xdg-desktop-portal support for pipewire serial has been merged as of pre-release 1.21.2: https://github.com/flatpak/xdg-desktop-portal/releases/tag/1.21.2 Implementing backends will still need to be updated so it'll likely be the next stable release that will be easily testable. |
a9e9764 to
0d869d4
Compare
|
KWin 6.7.0 finally supports pipewire objectserial (working great with kwingrab) but xdg-desktop-portal-kde still needs to be updated as that is still not returning a value for pipewire-serial yet. Looks like I'll have to look at other implementations just to test this so we can finally merge it. Thankfully the underlying changes to pipewire.cpp's connection handling are already validated and working properly (using kwingrab). |
418f658 to
988e5a1
Compare
|
I'll mark this as ready for review as it should work from what is in the portal documentation. I still haven't found any portal implementation that actually provides this on an available version but the pipewire part I've been able to test using kwingrab and the portal adaption is just adding another parameter read from the portal (that currently fails and sets the necessary invalid indicator for object serial). If merged after #5302 any major issues that can still occur should be transparently handled by the fallback to node id implemented there. |
988e5a1 to
4870dba
Compare
Bundle ReportBundle size has no change ✅ |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5060 +/- ##
==========================================
- Coverage 17.86% 17.85% -0.02%
==========================================
Files 111 111
Lines 24596 24602 +6
Branches 10890 10892 +2
==========================================
- Hits 4395 4393 -2
+ Misses 17811 15908 -1903
- Partials 2390 4301 +1911
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 65 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
|



Description
This is a PR to implement the upcoming changes on XDG portal to utilize pipewire-serial for stream selection instead of pipewire's node id. For more information see: flatpak/xdg-desktop-portal#979
The groundwork for using object serial with pipewire.cpp was done in #5054. This PR contains the changes to pass the serial received from XDG portal forward to pipewire_display_t.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage