Skip to content

fix(video): check encoder started up before trying to flush frames on destruction #5257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kishi85 wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

fix(video): check encoder started up before trying to flush frames on destruction #5257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/video.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,8 @@ namespace video {
avcodec_encode_session_t(avcodec_encode_session_t &&other) noexcept = default;

~avcodec_encode_session_t() {
// Flush any remaining frames in the encoder
if (avcodec_send_frame(avcodec_ctx.get(), nullptr) == 0) {
// Flush any remaining frames in the encoder if the encoder started up (frame num > delay)
if (avcodec_ctx->frame_num > avcodec_ctx->delay && avcodec_send_frame(avcodec_ctx.get(), nullptr) == 0) {
packet_raw_avcodec pkt;
while (avcodec_receive_packet(avcodec_ctx.get(), pkt.av_packet) == 0);
}
Expand Down