build: stop silently falling back to the latest build-deps release - #5645
Open
sresarehumantoo wants to merge 1 commit into
Open
build: stop silently falling back to the latest build-deps release#5645sresarehumantoo wants to merge 1 commit into
sresarehumantoo wants to merge 1 commit into
Conversation
When cmake cannot resolve a tag for the third-party/build-deps submodule it quietly downloads the LATEST build-deps release instead. The build then pairs prebuilt FFmpeg binaries from one release with the nv-codec-headers taken from the pinned submodule, so what gets linked no longer matches what the pin says, and the build stops being reproducible. A normal recursive clone resolves the tag and is unaffected. It is source tarballs, tagless or shallow clones, and any build-deps directory that is not a git repository that silently take the fallback, and the resulting breakage surfaces far from its cause: a Video Codec SDK version guard tripping is a typical symptom, which points at the NVENC code rather than at the dependency that was swapped underneath it. Honor an explicitly supplied FFMPEG_RELEASE_TAG so the release can be pinned without git, and turn the fallback into a warning that names the failure mode rather than a status line that reads like business as usual. Behavior when the tag resolves normally is unchanged. Verified all three paths: tag resolvable (unchanged), tag unresolvable (warns and still configures), and tag unresolvable with -DFFMPEG_RELEASE_TAG set (honored).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cmake/dependencies/ffmpeg.cmake resolves the prebuilt FFmpeg release from the third-party/build-deps submodule's git tag; when it cannot resolve one it downloads releases/latest silently instead. On non-Windows, nv-codec-headers come from the pinned submodule (cmake/compile_definitions/common.cmake:217) while the prebuilt binaries come from whatever release was downloaded, so a fallback pairs mismatched halves and the build stops being reproducible. A normal recursive clone is unaffected. Source tarballs, tagless or shallow clones, and any build-deps dir that is not a git repo take the fallback.
This was found in a downstream fork, where a Video Codec SDK guard tripped after the bundled nvEncodeAPI.h moved 13.0 → 13.1; upstream's exposure is the header/binary pairing rather than that guard.
The goal of the change is to honor an explicitly supplied -DFFMPEG_RELEASE_TAG and make the fallback a WARNING naming the failure mode rather than a STATUS line. Behavior when the tag resolves normally is unchanged.
All three paths verified, tag resolvable (unchanged), tag unresolvable (warns, still configures), tag unresolvable + -DFFMPEG_RELEASE_TAG is honored.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.