fix(linux/nvenc): select HEVC RExt profile for YUV 4:4:4 encoding - #5691
Open
bitness wants to merge 1 commit into
Open
fix(linux/nvenc): select HEVC RExt profile for YUV 4:4:4 encoding#5691bitness wants to merge 1 commit into
bitness wants to merge 1 commit into
Conversation
This change fills in the required profile for YUV 4:4:4 chroma subsampling for HEVC through NVENC, which is the Rext profile both for 8-bit and 10-bit encoding. It does the same thing for NVENC that the quicksync encoder setup does. Before, when these fields were empty, no NVENC 4:4:4 options would be correctly probed: the encoder configuration for the probes would include fallback values inconsistent with the SDR444 and HDR444 requirements. As a result, they wouldn't appear in /serverinfo output and Moonlight would consider them unsupported. This would effectively lock Linux NVENC encoding to 4:2:0.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change fills in the required profile for YUV 4:4:4 chroma subsampling for HEVC through NVENC, which is the Rext profile both for 8-bit and 10-bit encoding. It does the same thing for NVENC that the quicksync encoder setup does.
Before, when these fields were empty, no NVENC 4:4:4 options would be correctly probed: the encoder configuration for the probes would include fallback values inconsistent with the SDR444 and HDR444 requirements. As a result, they wouldn't appear in /serverinfo output and Moonlight would consider them unsupported. This would effectively lock Linux NVENC encoding to 4:2:0.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.