Skip to content

fix(windows): suppress repeated Xbox input reports - #138

Merged
ReenigneArcher merged 1 commit into
masterfrom
fix/triggers
Sep 12, 2026
Merged

fix(windows): suppress repeated Xbox input reports#138
ReenigneArcher merged 1 commit into
masterfrom
fix/triggers

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Avoid resubmitting unchanged Xbox One and Series states so held shoulder buttons remain continuous for raw HID consumers while preserving real input transitions.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Avoid resubmitting unchanged Xbox One and Series states so held shoulder buttons remain continuous for raw HID consumers while preserving real input transitions.
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.53%. Comparing base (083e64b) to head (72ec1f8).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   73.45%   73.53%   +0.07%     
==========================================
  Files          34       34              
  Lines        9305     9317      +12     
  Branches     3471     3480       +9     
==========================================
+ Hits         6835     6851      +16     
+ Misses       2134     2081      -53     
- Partials      336      385      +49     
Flag Coverage Δ
FreeBSD 52.03% <ø> (ø)
Linux-Clang 55.11% <ø> (ø)
Linux-GCC 65.93% <ø> (ø)
Windows-MSVC 88.42% <100.00%> (+0.10%) ⬆️
Windows-MinGW-UCRT64 63.07% <91.66%> (+0.09%) ⬆️
macOS 48.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/windows/windows_backend.cpp 83.03% <100.00%> (+0.13%) ⬆️

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 083e64b...72ec1f8. Read the comment docs.

@ReenigneArcher
ReenigneArcher merged commit a54cc91 into master Sep 12, 2026
31 checks passed
@ReenigneArcher
ReenigneArcher deleted the fix/triggers branch September 12, 2026 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gamepad LB/RB repeat-fire while held after libvirtualhid migration; Xbox 360 profile produces no controller

1 participant