Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github): add github integration #368

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Nov 9, 2024

Description

This PR aims to more tightly integrate GitHub with our discord bot.

Main features to add

  1. Assign roles based on GitHub sponsorship status
  2. Assign dev-user role based on GitHub account... (whether it exists, has contributed, or something along those lines)

TODO:

  • Persist OAuth status?
  • Periodically check GitHub user's for sponsor status, and add user to sponsor roles, or revoke accordingly
  • Callback to public URL
  • Possible to hide disocrd bot IP?
  • Improved SSL certs
  • Update dockerfile
  • Update readme/docs

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 16.83168% with 84 lines in your changes missing coverage. Please review.

Project coverage is 44.40%. Comparing base (362aef2) to head (14cb7f9).

Files with missing lines Patch % Lines
src/crypto.py 0.00% 34 Missing ⚠️
src/webapp.py 0.00% 30 Missing ⚠️
src/discord/cogs/github_commands.py 48.57% 18 Missing ⚠️
src/__main__.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
- Coverage   46.81%   44.40%   -2.42%     
==========================================
  Files          15       17       +2     
  Lines         786      867      +81     
==========================================
+ Hits          368      385      +17     
- Misses        418      482      +64     
Files with missing lines Coverage Δ
src/__main__.py 0.00% <0.00%> (ø)
src/discord/cogs/github_commands.py 48.57% <48.57%> (ø)
src/webapp.py 0.00% <0.00%> (ø)
src/crypto.py 0.00% <0.00%> (ø)

@ReenigneArcher ReenigneArcher force-pushed the feat/github/add-github-integration branch from 9151446 to 14cb7f9 Compare November 9, 2024 23:24
@ReenigneArcher ReenigneArcher force-pushed the feat/github/add-github-integration branch from 14cb7f9 to 69a160c Compare November 10, 2024 05:37
Copy link

sonarcloud bot commented Nov 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue
1 Security Hotspot
1 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant