Merge pull request #972 from Lombiq/issue/OSOE-961

OSOE-961: Remove check-spelling usage
Lombiq · Feb 19, 2025 · ecd6dea · ecd6dea
2 parents 4e70148 + f90a92b
commit ecd6dea
Show file tree

Hide file tree

Showing 24 changed files with 21 additions and 174 deletions.
diff --git a/.github/actions/spelling/allow.txt b/.github/actions/spelling/allow.txt
diff --git a/.github/actions/spelling/excludes.txt b/.github/actions/spelling/excludes.txt
diff --git a/.github/actions/spelling/expect.txt b/.github/actions/spelling/expect.txt
diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml
@@ -53,25 +53,6 @@ jobs:
       # This way, we can see Node.js build issues in the build log.
       build-verbosity: minimal
 
-
-  spelling:
-    name: Spelling
-    uses: Lombiq/GitHub-Actions/.github/workflows/spelling.yml@dev
-    with:
-      additional-dictionaries: |
-        cspell:csharp/csharp.txt
-        cspell:css/dict/css.txt
-        cspell:fullstack/dict/fullstack.txt
-        cspell:html-symbol-entities/entities.txt
-        cspell:html/dict/html.txt
-        cspell:html/src/svg.txt
-        cspell:node/dict/node.txt
-        cspell:npm/dict/npm.txt
-        lombiq-lgha:dictionaries/Liquid.txt
-        lombiq-lgha:dictionaries/Lombiq.people.txt
-        lombiq-lgha:dictionaries/Security.txt
-        lombiq-lgha:dictionaries/Xml.txt
-
   codespell:
     name: Codespell
     uses: Lombiq/GitHub-Actions/.github/workflows/codespell.yml@dev
@@ -91,7 +72,7 @@ jobs:
 
   post-pull-request-checks-automation:
     name: Post Pull Request Checks Automation
-    needs: [build-and-test-larger-runners, build-and-test-nuget-test, spelling, codespell, powershell-static-code-analysis]
+    needs: [build-and-test-larger-runners, build-and-test-nuget-test, codespell, powershell-static-code-analysis]
     if: github.event.pull_request != ''
     uses: Lombiq/GitHub-Actions/.github/workflows/post-pull-request-checks-automation.yml@dev
     secrets:

diff --git a/Lombiq.OSOCE.sln b/Lombiq.OSOCE.sln
@@ -179,15 +179,6 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Lombiq.Hosting.BuildVersion
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Lombiq.Hosting.MediaTheme.Targets", "src\Themes\Lombiq.Hosting.MediaTheme\Lombiq.Hosting.MediaTheme.Targets\Lombiq.Hosting.MediaTheme.Targets.csproj", "{8C24107C-10AA-43EE-A85E-55173EB5B65F}"
 EndProject
-Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "actions", "actions", "{A48B16D8-61C2-4EAD-978E-5DD77121CFA1}"
-EndProject
-Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "spelling", "spelling", "{106B5DDD-D775-4D25-BE16-4569226620E0}"
-	ProjectSection(SolutionItems) = preProject
-		.github\actions\spelling\allow.txt = .github\actions\spelling\allow.txt
-		.github\actions\spelling\excludes.txt = .github\actions\spelling\excludes.txt
-		.github\actions\spelling\expect.txt = .github\actions\spelling\expect.txt
-	EndProjectSection
-EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Lombiq.ContentEditors", "src\Modules\Lombiq.ContentEditors\Lombiq.ContentEditors\Lombiq.ContentEditors.csproj", "{1B7C5C5D-E20F-4707-A0B5-8602DF7DA78D}"
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Lombiq.ContentEditors.Samples", "src\Modules\Lombiq.ContentEditors\Lombiq.ContentEditors.Samples\Lombiq.ContentEditors.Samples.csproj", "{66571E77-70C3-4A1E-8C0F-9E15F933E771}"
@@ -1506,8 +1497,6 @@ Global
 		{8D054C07-A74B-4A37-B407-ED7BFE7C077B} = {11E06A11-1733-408D-BB2F-BFA07075F812}
 		{B261E437-D773-49A7-AA4B-72CFE7A8DE35} = {6ED7E28F-0556-471C-8AD1-5BB0941411DD}
 		{8C24107C-10AA-43EE-A85E-55173EB5B65F} = {11F2CB14-D92A-484F-9C1E-2836B1B04DB8}
-		{A48B16D8-61C2-4EAD-978E-5DD77121CFA1} = {719F19E1-0B20-490C-B325-74E5FD6C838C}
-		{106B5DDD-D775-4D25-BE16-4569226620E0} = {A48B16D8-61C2-4EAD-978E-5DD77121CFA1}
 		{1B7C5C5D-E20F-4707-A0B5-8602DF7DA78D} = {11E06A11-1733-408D-BB2F-BFA07075F812}
 		{66571E77-70C3-4A1E-8C0F-9E15F933E771} = {11E06A11-1733-408D-BB2F-BFA07075F812}
 		{C90E70CD-B792-4C1D-BE8A-FB47C1C33A36} = {6ED7E28F-0556-471C-8AD1-5BB0941411DD}

diff --git a/src/Libraries/Lombiq.HelpfulLibraries b/src/Libraries/Lombiq.HelpfulLibraries
diff --git a/src/Libraries/Lombiq.OrchardCoreApiClient b/src/Libraries/Lombiq.OrchardCoreApiClient
diff --git a/src/Modules/Lombiq.ChartJs b/src/Modules/Lombiq.ChartJs
diff --git a/src/Modules/Lombiq.DataTables b/src/Modules/Lombiq.DataTables
diff --git a/src/Modules/Lombiq.HelpfulExtensions b/src/Modules/Lombiq.HelpfulExtensions
diff --git a/src/Modules/Lombiq.Hosting.Azure.ApplicationInsights b/src/Modules/Lombiq.Hosting.Azure.ApplicationInsights
diff --git a/src/Modules/Lombiq.Hosting.Tenants b/src/Modules/Lombiq.Hosting.Tenants
diff --git a/src/Modules/Lombiq.Privacy b/src/Modules/Lombiq.Privacy
diff --git a/src/Modules/Lombiq.TrainingDemo b/src/Modules/Lombiq.TrainingDemo
diff --git a/src/Modules/Lombiq.VueJs b/src/Modules/Lombiq.VueJs
diff --git a/src/Modules/Lombiq.Walkthroughs b/src/Modules/Lombiq.Walkthroughs
diff --git a/src/Themes/Lombiq.BaseTheme b/src/Themes/Lombiq.BaseTheme
diff --git a/src/Themes/Lombiq.Hosting.MediaTheme b/src/Themes/Lombiq.Hosting.MediaTheme
diff --git a/src/Utilities/Lombiq.NodeJs.Extensions b/src/Utilities/Lombiq.NodeJs.Extensions
diff --git a/test/Lombiq.OSOCE.Tests.UI/Tests/ElasticsearchTests/BehaviorElasticsearchTests.cs b/test/Lombiq.OSOCE.Tests.UI/Tests/ElasticsearchTests/BehaviorElasticsearchTests.cs
@@ -38,9 +38,9 @@ await context.Application.UsingScopeAsync(async shellScope =>
                     {
                         var elasticsearchIndexManager = shellScope.ServiceProvider.GetRequiredService<ElasticIndexManager>();
 
-                        if (!await elasticsearchIndexManager.ExistsAsync("elasticsearchshouldwork")) return; // #spell-check-ignore-line
+                        if (!await elasticsearchIndexManager.ExistsAsync("elasticsearchshouldwork")) return;
 
-                        await elasticsearchIndexManager.DeleteIndex("elasticsearchshouldwork"); // #spell-check-ignore-line
+                        await elasticsearchIndexManager.DeleteIndex("elasticsearchshouldwork");
                     });
                 }
             },

diff --git a/test/Lombiq.UITestingToolbox b/test/Lombiq.UITestingToolbox
diff --git a/tools/Lombiq.Analyzers b/tools/Lombiq.Analyzers
diff --git a/tools/Lombiq.Analyzers.PowerShell b/tools/Lombiq.Analyzers.PowerShell
diff --git a/tools/Lombiq.GitHub.Actions b/tools/Lombiq.GitHub.Actions
+16 −16		Lombiq.HelpfulLibraries.AspNetCore/Security/CdnContentSecurityPolicyProvider.cs
+1 −1		Lombiq.HelpfulLibraries.Common/Extensions/ExceptionExtensions.cs
+1 −1		Lombiq.HelpfulLibraries.Common/Extensions/StringExtensions.cs
+1 −1		Lombiq.HelpfulLibraries.Common/Utilities/CultureHelpers.cs
+3 −3		Lombiq.HelpfulLibraries.OrchardCore/Data/QueryExtensions.cs
+1 −1		Lombiq.HelpfulLibraries.OrchardCore/Security/ExternalLoginContentSecurityPolicyProvider.cs
+3 −3		Lombiq.HelpfulLibraries.OrchardCore/Users/PasswordHelper.cs
+4 −4		Readme.md
+2 −2		Lombiq.OrchardCoreApiClient.Tester/Program.cs
+1 −1		Lombiq.OrchardCoreApiClient.Tests.UI/Extensions/TestCaseUITestContextExtensions.cs
+1 −1		Lombiq.OrchardCoreApiClient/Constants/Timezones.cs
+3 −3		Lombiq.DataTables.Tests/UnitTests/Services/LiquidTests.cs
+1 −1		Lombiq.DataTables/Assets/Scripts/lombiq-datatables.js
+1 −1		Lombiq.DataTables/Extensions/DataTableContentItemExtensions.cs
+2 −2		Lombiq.DataTables/ResourceManagementOptionsConfiguration.cs
+1 −1		Lombiq.DataTables/Services/DataTableDataProviderBase.cs
+1 −1		Lombiq.DataTables/Views/Lombiq.DataTable.cshtml
+3 −3		Lombiq.HelpfulExtensions/Extensions/Trumbowyg/TrumbowygResourceManagementOptionsConfiguration.cs
+6 −6		Readme.md
+1 −1		Lombiq.Hosting.Tenants.EmailQuotaManagement/Views/DashboardQuotaMessage.cshtml
+1 −1		Lombiq.Hosting.Tenants.FeaturesGuard/Handlers/FeaturesEventHandler.cs
+1 −1		Lombiq.Hosting.Tenants.Management/Views/ShellSettingsEditor.cshtml
+1 −1		Lombiq.Hosting.Tenants.MediaStorageManagement.Tests.UI/Extensions/TestCaseUITestContextExtensions.cs
+1 −1		Lombiq.VueJs.Samples/Views/VueSfc/EnhancedList.cshtml
+1 −1		Lombiq.VueJs/Assets/Scripts/helpers/process-helpers.js
+1 −1		Lombiq.VueJs/Assets/Scripts/helpers/rollup-pipeline.js
+1 −1		Lombiq.VueJs/Assets/Scripts/helpers/rollup-plugin-vue-sfc-orchard-core.js
+1 −1		Lombiq.VueJs/Assets/Scripts/helpers/vue-sfc-compiler-pipeline.js
+6 −6		Lombiq.Walkthroughs.Test.UI/Extensions/TestCaseUITestContextExtensions.cs
+16 −16		Lombiq.Walkthroughs/Assets/Scripts/walkthroughs.js
+1 −1		Lombiq.BaseTheme/Assets/Styles/abstracts/_mixins.scss
+4 −4		Readme.md
+2 −2		Lombiq.Hosting.MediaTheme.Deployer/Program.cs
+2 −2		Readme.md
+1 −1		Lombiq.NodeJs.Extensions/Docs/Styles.md
+1 −1		Lombiq.NodeJs.Extensions/Lombiq.NodeJs.Extensions.targets
+5 −5		Readme.md