-
Notifications
You must be signed in to change notification settings - Fork 6.4k
Gitchallenge Tws9 #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Gitchallenge Tws9 #483
Conversation
WalkthroughDocumentation-only updates: minor text insertion in Git basics README, addition of a contributor name in the root README, and two new text files—one with Week‑4 Git/GitHub challenge instructions and one with a single name entry. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
completed challenge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
2025/git/01_Git_and_Github_Basics/README.md (1)
71-77
: Do not embed PATs in remotes; replace with safer commands to prevent token leakage.Putting a PAT in the remote URL risks accidental leakage via shell history, logs, screenshots, and .git/config. Prefer HTTPS with credential helpers or GitHub CLI. The exercise can still be completed without hardcoding the token.
Apply this diff to replace token-in-URL with safer defaults and guidance:
-```bash -git remote add origin https://<your-username>:<your-PAT>@github.com/<your-username>/90DaysOfDevOps.git -``` -If a remote named `origin` already exists, update it with: -```bash -git remote set-url origin https://<your-username>:<your-PAT>@github.com/<your-username>/90DaysOfDevOps.git -``` +```bash +# Recommended: use HTTPS without embedding tokens (you'll be prompted; use your PAT as password) +git remote add origin https://github.com/<your-username>/90DaysOfDevOps.git +``` +If a remote named `origin` already exists, update it with: +```bash +git remote set-url origin https://github.com/<your-username>/90DaysOfDevOps.git +``` + +Safer alternatives: +- Use Git Credential Manager (recommended) or OS keychain-backed helpers so you are not repeatedly prompted. +- Or use GitHub CLI: + ```bash + gh auth login + gh repo set-default <your-username>/90DaysOfDevOps + ``` +Cleanup tip (if you previously embedded a PAT): rotate the token on GitHub and update `.git/config` to remove any PAT-bearing URLs.
🧹 Nitpick comments (4)
networking.txt (1)
1-1
: Clarify purpose and remove trailing whitespace; consider relocating or dropping the file.The file appears to be a personal note with a trailing space and no clear linkage to the Week‑4 Git challenge docs. If this was meant as your
info.txt
(per the challenge), please move it under the appropriate challenge directory and name it accordingly. Otherwise, remove it to keep the repo clean.Proposed cleanup to trim trailing whitespace:
-Himanshu +HimanshuDo you want me to open a follow-up to relocate or delete this file?
README.md (1)
12-12
: Avoid inserting personal names under “Steps”; move to an appropriate section.Placing a contributor name under “## Steps:” confuses the structure. Consider adding yourself to a dedicated Participants/Contributors area (or rely on the existing contributors badge), not inside the steps list.
Apply this diff to keep the Steps section focused:
-Himanshu Namdeo
If you want, I can add a “Participants” section with your name in a follow-up PR.
solution/gitsol.txt (2)
15-16
: Fix incomplete sentence and improve clarity for forking instructions.Apply this wording tweak:
-Visit this repository and fork it to your own GitHub account. If not done yet. +Visit this repository and fork it to your own GitHub account (if you haven’t already).
1-150
: Consider converting this to Markdown for readability and consistency.You have headings, lists, and commands—Markdown would render these properly, enable clickable links, and avoid formatting drift versus the README version. Also, there’s duplicated content between this file and the 01_Git_and_Github_Basics README; centralize the canonical instructions and reference them to avoid divergence.
I can consolidate the instructions into a single Markdown source and update cross-links if you’d like.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these settings in your CodeRabbit configuration.
📒 Files selected for processing (4)
2025/git/01_Git_and_Github_Basics/README.md
(1 hunks)README.md
(1 hunks)networking.txt
(1 hunks)solution/gitsol.txt
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
solution/gitsol.txt
[grammar] ~11-~11: There might be a mistake here.
Context: ...s provided at the end). Challenge Tasks Task 1: Fork and Clone the Repository Fo...
(QB_NEW_EN)
[grammar] ~12-~12: There might be a mistake here.
Context: ...ks Task 1: Fork and Clone the Repository Fork the Repository: Visit this reposit...
(QB_NEW_EN)
[grammar] ~18-~18: There might be a mistake here.
Context: ...Clone the forked repository using HTTPS: git clone Change directo...
(QB_NEW_EN)
[grammar] ~19-~19: There might be a mistake here.
Context: ...y using HTTPS: git clone Change directory into the cloned reposit...
(QB_NEW_EN)
[grammar] ~20-~20: There might be a mistake here.
Context: ...ge directory into the cloned repository: cd 2025/git/01_Git_and_Github_Basics Tas...
(QB_NEW_EN)
[grammar] ~21-~21: There might be a mistake here.
Context: ...ry: cd 2025/git/01_Git_and_Github_Basics Task 2: Initialize a Local Repository an...
(QB_NEW_EN)
[grammar] ~22-~22: There might be a mistake here.
Context: ...ize a Local Repository and Create a File Set Up Your Challenge Directory: Inside...
(QB_NEW_EN)
[grammar] ~25-~25: There might be a mistake here.
Context: ...eate a new directory for this challenge: mkdir week-4-challenge cd week-4-challen...
(QB_NEW_EN)
[grammar] ~26-~26: There might be a mistake here.
Context: ...r this challenge: mkdir week-4-challenge cd week-4-challenge Initialize a Git Rep...
(QB_NEW_EN)
[grammar] ~27-~27: There might be a mistake here.
Context: ...dir week-4-challenge cd week-4-challenge Initialize a Git Repository: Initialize...
(QB_NEW_EN)
[grammar] ~30-~30: There might be a mistake here.
Context: ...e the directory as a new Git repository: git init Create a File: Create a file n...
(QB_NEW_EN)
[grammar] ~31-~31: There might be a mistake here.
Context: ...ectory as a new Git repository: git init Create a File: Create a file named info...
(QB_NEW_EN)
[grammar] ~37-~37: There might be a mistake here.
Context: ...e and Commit Your File: Stage the file: git add info.txt Commit the file with a ...
(QB_NEW_EN)
[grammar] ~38-~38: There might be a mistake here.
Context: ... File: Stage the file: git add info.txt Commit the file with a descriptive messa...
(QB_NEW_EN)
[grammar] ~39-~39: There might be a mistake here.
Context: ...mit the file with a descriptive message: git commit -m "Initial commit: Add info....
(QB_NEW_EN)
[grammar] ~40-~40: There might be a mistake here.
Context: ... Add info.txt with introductory content" Task 3: Configure Remote URL with PAT an...
(QB_NEW_EN)
[grammar] ~41-~41: There might be a mistake here.
Context: ...figure Remote URL with PAT and Push/Pull Configure Remote URL with Your PAT: To a...
(QB_NEW_EN)
[grammar] ~42-~42: There might be a mistake here.
Context: ...Pull Configure Remote URL with Your PAT: To avoid entering your Personal Access T...
(QB_NEW_EN)
[grammar] ~49-~49: There might be a mistake here.
Context: ...b.com//90DaysOfDevOps.git If a remote named origin already exists,...
(QB_NEW_EN)
[grammar] ~52-~52: There might be a mistake here.
Context: ...b.com//90DaysOfDevOps.git Push Your Commit to Remote: Push your c...
(QB_NEW_EN)
[grammar] ~55-~55: There might be a mistake here.
Context: ...h (typically main) and set the upstream: git push -u origin main (Optional) Pull ...
(QB_NEW_EN)
[grammar] ~56-~56: There might be a mistake here.
Context: ...et the upstream: git push -u origin main (Optional) Pull Remote Changes: Verify ...
(QB_NEW_EN)
[grammar] ~66-~66: There might be a mistake here.
Context: ...Task 5: Advanced Branching and Switching Create a New Branch: Create a branch ca...
(QB_NEW_EN)
[grammar] ~69-~69: There might be a mistake here.
Context: ... Create a branch called feature-update: git branch feature-update Switch to the ...
(QB_NEW_EN)
[grammar] ~70-~70: There might be a mistake here.
Context: ...eature-update: git branch feature-update Switch to the New Branch: Switch using ...
(QB_NEW_EN)
[grammar] ~73-~73: There might be a mistake here.
Context: ...he New Branch: Switch using git switch: git switch feature-update Alternatively,...
(QB_NEW_EN)
[grammar] ~74-~74: There might be a mistake here.
Context: ...ng git switch: git switch feature-update Alternatively, you can use: git checkout...
(QB_NEW_EN)
[grammar] ~75-~75: There might be a mistake here.
Context: ...ature-update Alternatively, you can use: git checkout feature-update Modify the F...
(QB_NEW_EN)
[grammar] ~76-~76: There might be a mistake here.
Context: ...you can use: git checkout feature-update Modify the File and Commit Changes: Edi...
(QB_NEW_EN)
[grammar] ~80-~80: There might be a mistake here.
Context: ...vements). Stage and commit your changes: git add info.txt git commit -m "Feature ...
(QB_NEW_EN)
[grammar] ~81-~81: There might be a mistake here.
Context: ...nd commit your changes: git add info.txt git commit -m "Feature update: Enhance i...
(QB_NEW_EN)
[grammar] ~82-~82: There might be a mistake here.
Context: ...nhance info.txt with additional details" git push origin feature-update Merge thi...
(QB_NEW_EN)
[grammar] ~83-~83: There might be a mistake here.
Context: ... details" git push origin feature-update Merge this branch to main via a Pull Req...
(QB_NEW_EN)
[grammar] ~84-~84: There might be a mistake here.
Context: ...ch to main via a Pull Request on GitHub. (Advanced) Optional Extra Challenge: If...
(QB_NEW_EN)
[grammar] ~94-~94: There might be a mistake here.
Context: ...rative development. Consider addressing: Isolating features and bug fixes Facilit...
(QB_NEW_EN)
[grammar] ~95-~95: There might be a mistake here.
Context: ...essing: Isolating features and bug fixes Facilitating parallel development Reduci...
(QB_NEW_EN)
[grammar] ~96-~96: There might be a mistake here.
Context: ... fixes Facilitating parallel development Reducing merge conflicts Enabling effect...
(QB_NEW_EN)
[grammar] ~97-~97: There might be a mistake here.
Context: ...lel development Reducing merge conflicts Enabling effective code reviews Bonus Ta...
(QB_NEW_EN)
[grammar] ~98-~98: There might be a mistake here.
Context: ...onflicts Enabling effective code reviews Bonus Task: Explore SSH Authentication G...
(QB_NEW_EN)
[grammar] ~99-~99: There might be a mistake here.
Context: ...s Bonus Task: Explore SSH Authentication Generate an SSH Key (if not already set ...
(QB_NEW_EN)
[grammar] ~111-~111: There might be a mistake here.
Context: ...Change the remote URL from HTTPS to SSH: git remote set-url origin [email protected]...
(QB_NEW_EN)
[grammar] ~112-~112: There might be a mistake here.
Context: ...b.com:/90DaysOfDevOps.git Push Your Branch Using SSH: Test the SS...
(QB_NEW_EN)
[grammar] ~115-~115: There might be a mistake here.
Context: ...e SSH connection by pushing your branch: git push origin feature-update 📢 How to...
(QB_NEW_EN)
[grammar] ~116-~116: There might be a mistake here.
Context: ...r branch: git push origin feature-update 📢 How to Submit Push Your Final Work: ...
(QB_NEW_EN)
[grammar] ~117-~117: There might be a mistake here.
Context: ... origin feature-update 📢 How to Submit Push Your Final Work: Ensure your branch...
(QB_NEW_EN)
[grammar] ~118-~118: There might be a mistake here.
Context: ...e 📢 How to Submit Push Your Final Work: Ensure your branch (e.g., feature-update)...
(QB_NEW_EN)
[grammar] ~126-~126: There might be a mistake here.
Context: ...cess and list the Git commands you used. Share Your Experience on LinkedIn: Writ...
(QB_NEW_EN)
[grammar] ~132-~132: There might be a mistake here.
Context: ...rticles you create about this challenge. Additional Resources Git Documentation: ...
(QB_NEW_EN)
[grammar] ~133-~133: There might be a mistake here.
Context: ...out this challenge. Additional Resources Git Documentation: https://git-scm.com/d...
(QB_NEW_EN)
[grammar] ~134-~134: There might be a mistake here.
Context: ... Additional Resources Git Documentation: https://git-scm.com/docs Creating a Per...
(QB_NEW_EN)
[grammar] ~137-~137: There might be a mistake here.
Context: .../docs Creating a Personal Access Token: GitHub PAT Setup Forking and Cloning Re...
(QB_NEW_EN)
[grammar] ~140-~140: There might be a mistake here.
Context: ...Setup Forking and Cloning Repositories: Fork a Repository | Cloning a Repository...
(QB_NEW_EN)
[grammar] ~143-~143: There might be a mistake here.
Context: ...ository SSH Authentication with GitHub: Connecting to GitHub with SSH Understan...
(QB_NEW_EN)
[grammar] ~146-~146: There might be a mistake here.
Context: ...SSH Understanding Branching Strategies: Git Branching Strategies
(QB_NEW_EN)
2025/git/01_Git_and_Github_Basics/README.md
[grammar] ~14-~14: There might be a mistake here.
Context: ...ls provided at the end). --- Jay shree mahakal ## Challenge Tasks ### Task 1: Fork and Cl...
(QB_NEW_EN)
README.md
[grammar] ~12-~12: There might be a mistake here.
Context: ...e](./TOC.md). ## Steps: Himanshu Namdeo - Fork[https://github.com/LondheShubham153...
(QB_NEW_EN)
|
||
--- | ||
|
||
Jay shree mahakal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Remove non-technical/personal line to keep docs neutral and professional.
“Jay shree mahakal” is out of scope for technical documentation and may not be appropriate for a community repo.
Apply this diff:
-Jay shree mahakal
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Jay shree mahakal |
🧰 Tools
🪛 LanguageTool
[grammar] ~14-~14: There might be a mistake here.
Context: ...ls provided at the end). --- Jay shree mahakal ## Challenge Tasks ### Task 1: Fork and Cl...
(QB_NEW_EN)
🤖 Prompt for AI Agents
In 2025/git/01_Git_and_Github_Basics/README.md around line 14, remove the
personal/non-technical line "Jay shree mahakal" to keep the documentation
neutral and professional; edit the file to delete that line and ensure
surrounding content and formatting remain consistent (no other text changes).
git remote add origin https://<your-username>:<your-PAT>@github.com/<your-username>/90DaysOfDevOps.git | ||
If a remote named origin already exists, update it with: | ||
|
||
git remote set-url origin https://<your-username>:<your-PAT>@github.com/<your-username>/90DaysOfDevOps.git | ||
Push Your Commit to Remote: | ||
|
||
Push your current branch (typically main) and set the upstream: | ||
git push -u origin main | ||
(Optional) Pull Remote Changes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace token-in-URL guidance with safer approaches; prevent PAT leakage.
Embedding PATs in remotes is risky (shell history, logs, screenshots, and .git/config). Prefer HTTPS with credential helpers or gh CLI.
Apply this diff:
-git remote add origin https://<your-username>:<your-PAT>@github.com/<your-username>/90DaysOfDevOps.git
-If a remote named origin already exists, update it with:
-
-git remote set-url origin https://<your-username>:<your-PAT>@github.com/<your-username>/90DaysOfDevOps.git
+git remote add origin https://github.com/<your-username>/90DaysOfDevOps.git
+If a remote named origin already exists, update it with:
+
+git remote set-url origin https://github.com/<your-username>/90DaysOfDevOps.git
+
+Tips:
+- When prompted for credentials on push, use your PAT as the password.
+- Prefer using Git Credential Manager or GitHub CLI (`gh auth login`) to avoid storing secrets in plain text.
+- If you previously embedded a PAT in a URL, rotate the token on GitHub and remove it from `.git/config`.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
git remote add origin https://<your-username>:<your-PAT>@github.com/<your-username>/90DaysOfDevOps.git | |
If a remote named origin already exists, update it with: | |
git remote set-url origin https://<your-username>:<your-PAT>@github.com/<your-username>/90DaysOfDevOps.git | |
Push Your Commit to Remote: | |
Push your current branch (typically main) and set the upstream: | |
git push -u origin main | |
(Optional) Pull Remote Changes: | |
git remote add origin https://github.com/<your-username>/90DaysOfDevOps.git | |
If a remote named origin already exists, update it with: | |
git remote set-url origin https://github.com/<your-username>/90DaysOfDevOps.git | |
Tips: | |
- When prompted for credentials on push, use your PAT as the password. | |
- Prefer using Git Credential Manager or GitHub CLI (`gh auth login`) to avoid storing secrets in plain text. | |
- If you previously embedded a PAT in a URL, rotate the token on GitHub and remove it from `.git/config`. | |
Push Your Commit to Remote: | |
Push your current branch (typically main) and set the upstream: | |
git push -u origin main | |
(Optional) Pull Remote Changes: |
🧰 Tools
🪛 LanguageTool
[grammar] ~49-~49: There might be a mistake here.
Context: ...b.com//90DaysOfDevOps.git If a remote named origin already exists,...
(QB_NEW_EN)
[grammar] ~52-~52: There might be a mistake here.
Context: ...b.com//90DaysOfDevOps.git Push Your Commit to Remote: Push your c...
(QB_NEW_EN)
[grammar] ~55-~55: There might be a mistake here.
Context: ...h (typically main) and set the upstream: git push -u origin main (Optional) Pull ...
(QB_NEW_EN)
[grammar] ~56-~56: There might be a mistake here.
Context: ...et the upstream: git push -u origin main (Optional) Pull Remote Changes: Verify ...
(QB_NEW_EN)
🤖 Prompt for AI Agents
In solution/gitsol.txt around lines 49 to 57, the instructions embed a personal
access token directly in the remote URL which risks leaking credentials; replace
that guidance with safe alternatives: remove any examples that include tokens in
URLs and instead instruct users to configure a credential helper
(git-credential-manager, osxkeychain, or credential-store) or authenticate via
the GitHub CLI (gh auth login), then add the remote using the standard HTTPS URL
without credentials and push normally (git remote add origin
https://github.com/<your-username>/90DaysOfDevOps.git; git push -u origin main).
Also add a note to rotate any PATs that may have been exposed and to prefer SSH
keys or gh CLI for automation.
Stale pull request message |
Summary by CodeRabbit