Skip to content

Update ftl-hyperspace #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
carsakiller merged 3 commits into from
May 30, 2025
Merged

Update ftl-hyperspace #258

carsakiller merged 3 commits into from
May 30, 2025

Conversation

@ranhai613
Copy link
Contributor

@ranhai613 ranhai613 commented May 29, 2025 •
edited
Loading

Update for Hyperspace version 1.19.1.
In advance, thanks who will take care of this pr.

One question:
During update, I switched the target branch from main to publish for submodule. Should I add branch = publish to https://github.com/LuaLS/LLS-Addons/blob/main/.gitmodules ?

@carsakiller carsakiller added the Addon Update An update for an existing addon label May 29, 2025
@carsakiller
Copy link
Collaborator

carsakiller commented May 29, 2025

Hello, @ranhai613! Yes, in order for Git to target the non-main branch, the entry in .gitmodules for this addon must state the new target branch. See luvit for an example. Then you will have to update the submodule again in order for it to sync the change.

@ranhai613
Copy link
Contributor Author

ranhai613 commented May 30, 2025

Hello, @ranhai613! Yes, in order for Git to target the non-main branch, the entry in .gitmodules for this addon must state the new target branch. See luvit for an example. Then you will have to update the submodule again in order for it to sync the change.

Gotcha! Now I think its okay.

carsakiller
carsakiller approved these changes May 30, 2025
View reviewed changes
Copy link
Collaborator

@carsakiller carsakiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks good! 🙂

@carsakiller carsakiller merged commit 9006c82 into LuaLS:main May 30, 2025
1 check passed
@ranhai613 ranhai613 deleted the update-ftl-hyperspace branch September 26, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carsakiller carsakiller carsakiller approved these changes

Assignees

No one assigned

Labels

Addon Update An update for an existing addon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ranhai613 @carsakiller