Added ORDER BY to delete operation + update composer.json + fix tests

[ildyria]

Copy of #6 to v6 branch (to align with upstream repo with v6).

Partially fixes LycheeOrg/Lychee#1251

As MySQL does not comly to ANSI SQL and does not support statement consistency, but only simple row consistency, the order of rows is important when a complete sub-tree is deleted.

[nagmat84]

I haven't checked the details, but did you only migrate #6 on top of the v6 branch? Please keep in mind that we already had to merge a couple of other bug fixes into our copy of the v5 branch, inter alia

• another fix for deletion some month ago
• a fix which uses a proper interface to check whether a model is a nested set node
• some fixes with respect to exception handling

This are only the fixes a do remember. Maybe there are more.

So basically, our v5 branch and the upstream v5 were diverted (not in the git sense, but in the sense that we had to fix a lot which never made it upstream). Have you checked that all these bug fixes are also in "our" v6?

[ildyria]

I took their v6, merged into your branch (which is based on our diverged v5) and created a pull request to a copy of their v6.

If you like git log --one-line

So unless I'm wrong, this PR to v6 basically contains all the changes you made to the v5 + #6 + passing tests :)

[nagmat84]

Understood. So I still need to find out what the original difference between upstream v5 and v6 is. I am always a little bit conservative with major upgrades.

[ildyria]

Understood. So I still need to find out what the original difference between upstream v5 and v6 is. I am always a little bit conservative with major upgrades.

It is just a bump of the Laravel version, code wise there is pretty much 0 change... I seriously do not know why they decided to make it v6. IMHO that was not needed.
The only reason why I would be in favor to align with them is to make it easier to integrate some of the potential fixes they may have in the future.

You can clearly see that their v6 does not add anything, especially given that the merge commit is quite empty:
f47602e

As for ec8e1d7
It is a fix that was applied on the v5 after the v5-v6 split on their repo.
I took the initiative to merge it here.

[nagmat84]

Some minor changes

[nagmat84]

LGTM.