Validate cwl

[grallewellyn]

Checks the syntax of the cwl in the API so that it fails on the POST request for the user, for example for running James's cwl the API POST request fails with

{"type": null, "title": "CWL file is not in the right format or is invalid.", "status": 400, "detail": "CWL file is not in the right format or is invalid.", "instance": ""}

This is deployed on DIT for testing

[marjo-luc]

When validating CWL for MAAP, we've been using both cwltool and ap-validator (the latter provides OGC validation). Should we be using both for here as well to make sure we are validating CWLs consistently?

See here: https://github.com/MAAP-Project/ogc-app-pack-generator

[grallewellyn]

@marjo-luc I agree and made the change

[sonarqubecloud]

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[sujen1412]

I do not agree with the way this is implemented. We should not run subprocess commands in an API.
Please look for a pythonic way to do this. Under heavy load in our current setup the api machine will start rejecting requests especially when we are relying on many external dependencies.

• Network to download CWL
• File IO to write to disk
• Subprocess to now validate that.
  Please see if you can do all in memory so only dependency is network.