Conversation
Noticed pytest will create multiple loggers for command line run This might be a bug with reopening loggers? Further testing might be needed In any case, to override logging behaviour when using in-library scripts, we can now pass a logger instance which will be used over the logging options in the command
disable mypy pre-commit PRs should check mypy, commits should just 'work' to avoid hassle when saving work and moving between workstations
LogSetupOptions.use_root toggles between the root logger and the relic.cli logger LogSetupOptions.add_handlers will not add a handlers to the cli logger Neither of these flags are used IFF the logger is manually passed in
Rush job, should have split into separate PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.