Conversation
Co-authored-by: CHAEEUN KIM <154000318+bongtta@users.noreply.github.com>
* fix: (QA/3) 홈으로 페이지 이동할 때 배너 이미지 로드 전에 텍스트만 뜨는 문제 해결 (#384) * fix: 홈으로 페이지 이동할 때 배너 이미지 로드 전에 텍스트만 뜨는 문제 해결 (#384) * fix: 배너 최소 높이 설정 (#384) * fix: 회원가입 design, gaEvent 수정 및 매칭 현황 내 중복 데이터 오류 해결 (#383) * fix: sign-up 페이지 배경색 짤리는 오류 수정 (#383) * fix: match-card-view gaEvent 삭제 (#383) * fix: gaEvent 위치 수정 (#383) * fix: 캐시가 섞이면서 데이터 중복되는 에러 해결 (#383) * fix: 주석 제거 (#383) --------- Co-authored-by: heesunee <heesun729@uos.ac.kr> --------- Co-authored-by: Yewon Kim <163109964+yeeeww@users.noreply.github.com> Co-authored-by: heesunee <heesun729@uos.ac.kr>
|
Caution Review failedThe pull request is closed. Walkthrough회원가입 페이지와 배너 카드의 레이아웃 클래스가 변경되었습니다. h-full 제거와 flex-1 적용으로 높이/성장 방식이 조정되었고, 배너 버튼에 min-h-[9.6rem]가 추가되었습니다. 로직, 상태, 이벤트 핸들러 변경은 없습니다. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes(없음) Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
MATEBALL-STORYBOOK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ Related Issue
Closes #388
Summary by CodeRabbit