Add Subject Alternative Names to self-siged certificate #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR. Will merge it before the next version of MISP is released 👍 |
ostefano
approved these changes
Mar 24, 2024
|
I did not realize i changed the permissions, sorry about that! |
|
@kelke Yep, noticed, and fixed it, no worries. |
dgujarathi
pushed a commit
to dgujarathi/misp-docker
that referenced
this pull request
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the self-signed certificate generated by openssl for nginx, only the Common Name is used for validating requests.
This behaviour is deprecated and will be removed from certain libraries in the future:
Feature: Remove support for common names in certificates
Remove support for common names in certificates; only support Subject Alt Names
I have noticed this while using the REST API with the python requests library, which generated the following warning for each request:
This commit does not delete existing certificates, only adds the SAN extension to newly generated ones.
I included:
Tested on debian 12 using the latest docker engine by docker.com