Skip to content

Split style checks into separate workflow #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025
Merged

Split style checks into separate workflow #542

merged 2 commits into from
May 29, 2025

Conversation

tompollard
Copy link
Member

Currently, style checks are integrated with functional tests in the same workflow. This meant that any style issues cause the entire test suite to fail.

This pull request:

  • Creates a new workflow file .github/workflows/style.yml for style checks
  • Removes style check step from the test workflow

The benefit of making this change is that it becomes easier to identify whether issues are related to code style or functionality.

@tompollard tompollard requested a review from briangow May 29, 2025 20:51
Copy link
Contributor

@briangow briangow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tompollard , looks good, thanks

@tompollard tompollard merged commit a629039 into main May 29, 2025
19 checks passed
@tompollard tompollard deleted the tp/split_tests branch May 29, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants