Recettes jetables : ajout de Slack et Sendgrid#1641
Draft
celine-m-s wants to merge 6 commits intomainfrom
Draft
Conversation
2 tasks
celine-m-s
force-pushed
the
review_apps
branch
from
f41e723 to
974cd58
Compare
celine-m-s
added
recette-jetable
celine-m-s
force-pushed
the
review_apps
branch
7 times, most recently
from
af91122 to
8d528a6
Compare
|
celine-m-s
force-pushed
the
review_apps
branch
3 times, most recently
from
bfd6324 to
60650ec
Compare
celine-m-s
force-pushed
the
review_apps
branch
4 times, most recently
from
19e7047 to
b65fea1
Compare
celine-m-s
force-pushed
the
review_apps
branch
3 times, most recently
from
3fc1495 to
a64f89d
Compare
celine-m-s
force-pushed
the
review_apps
branch
5 times, most recently
from
02a6d36 to
e5220c8
Compare
celine-m-s
force-pushed
the
recettes/sendgrid_slack
branch
from
a55b202 to
b632597
Compare
…nnalité en recette jetable
… la fonctionnalité en recette jetable
With the arrival of review apps and demo environment, we need to refine the actual production environment represented by the NODE_ENV. Introduce a new USER_ENVIRONMENT variable to specify which environment the user is using. Also, consider that the default environment is the production one to avoid all unwanted debugging or information leak. Start to clean up the isDev property mainly used to create fixture data. Cleaning can't be done completely because a table column is still using it. To do next: remove the column and do a data migration.
celine-m-s
force-pushed
the
recettes/sendgrid_slack
branch
from
b632597 to
0e2d88d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ajout de la préposition correspondant à l'environnement.
Les recettes jetables et la démo tournent dans un environnement de production. On ne peut donc pas utiliser
isDev. Ajouter le nom de l'environnement et le récupérer dans Nuxt me semble être la meilleure solution.Cela nous permettra aussi d'afficher le nom de l'environnement dans un bandeau statique, comme évoqué par l'équipe précédemment.