Fix: Return after decoding ResponseStreamEvent successfully #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neelvirdy
changed the title
Contributor
Author
|
@nezhyborets could I get a review on this small PR please? |
nezhyborets
approved these changes
Sep 11, 2025
Collaborator
|
@neelvirdy thanks for the PR, strange that PR didn't warn me that I initialized self more than once |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Return after decoding a ResponseStreamEvent successfully, instead of continuing to attempt other decoding strategies.
Why
Previously was seeing many decoding errors because the decoding logic would continue instead of returning.
Affected Areas
Responses API with Streaming