Ensure correct error propagation for sequential replies #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There were two related issues when a decoding error occurred for a route using
SequentialResultProvider
:SequentialResultProvider
was already initialized. Itsdeinit
would then send afinished
status, incorrectly masking the decoding error.catch
block would close the XPC transaction without first sending a properly formatted error message that the client-side provider could interpret.This resulted in the client receiving a
finished
status instead of an appropriate error.Solution
This PR addresses the issue with a two-part fix:
Delayed Initialization: The
SequentialResultProvider
is now created only after the incoming message has been successfully decoded. This ensures that a decoding failure is thrown and caught before the provider is ever instantiated, preventing itsdeinit
from sending a misleadingfinished
status.Corrected Error Handling: The server's error handling logic for sequential replies has been updated. It now explicitly sends a new XPC message containing the error details first, and only then closes the underlying XPC transaction.
These changes guarantee that decoding errors are correctly propagated to the client as an error state, not as a successful completion.