fix: improve header visibility in dark terminal themes#227
Open
HAOGRE wants to merge 1 commit into
Open
Conversation
Change header color from 'color(117)' (light blue) to 'bold bright_white' in dark background theme for better visibility across all dark terminals. The previous color(117) had insufficient contrast on certain dark terminal backgrounds (particularly blue-tinted backgrounds like iTerm2), making the title 'CLAUDE CODE USAGE MONITOR' nearly invisible. Fixes visibility issue where header sparkles and text were unreadable in dark mode on terminals with specific color configurations. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe dark background theme's "header" style in themes.py was changed from a light-blue ANSI color to "bold bright_white". No other theme mappings or public interfaces were modified. ChangesTheme color update
Estimated code review effort: 1 (Trivial) | ~2 minutes Estimated code review effortEstimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Maciek-roboblog Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Improve header visibility in dark terminal themes
Problem
In dark terminal themes, the header "✦ ✧ ✦ ✧ CLAUDE CODE USAGE MONITOR ✦ ✧ ✦ ✧" was nearly invisible on certain terminal configurations (particularly iTerm2 with dark backgrounds). The previous color
color(117)(light blue, RGB 135,215,255) had insufficient contrast on blue-tinted dark backgrounds.Root Cause
color(117)has a perceived brightness of ~196Solution
Changed the dark theme header color from:
to:
Changes
src/claude_monitor/terminal/themes.py(line 134)"header": "color(117)"- Light blue with 14:1 contrast ratio"header": "bold bright_white"- Bold bright white for maximum visibilityBenefits
Screenshots
Before — header is nearly invisible on an iTerm2 dark background (
--theme dark):After — header is clearly visible with bold bright white (same terminal, same theme):
Testing
get_dark_background_theme())Related: This is a complementary fix to PR #204 (which addressed Apple Terminal detection). While PR #204 fixed theme detection for Apple Terminal, this PR fixes the actual color contrast issue that affects visibility regardless of terminal type.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WitcsgcVw81J9hKwdCbZRF