Skip to content

Log HTTP host and port if web server is enabled#197

Open
CrosRoad95 wants to merge 1 commit into
MafiaHub:developfrom
CrosRoad95:patch-3
Open

Log HTTP host and port if web server is enabled#197
CrosRoad95 wants to merge 1 commit into
MafiaHub:developfrom
CrosRoad95:patch-3

Conversation

@CrosRoad95
Copy link
Copy Markdown
Contributor

@CrosRoad95 CrosRoad95 commented May 26, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Server startup logging now conditionally displays HTTP-related information only when the web server is enabled, reducing unnecessary log messages when the web server is disabled.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a4ce3db3-7331-4ab8-8126-51253e93bc1f

📥 Commits

Reviewing files that changed from the base of the PR and between a9aa0d6 and 59b0fe2.

📒 Files selected for processing (1)
  • code/framework/src/integrations/server/instance.cpp

Walkthrough

In Instance::Init, server startup logging for HTTP bind host and port is now conditionally gated behind the _opts.webServerEnabled flag. When the web server is disabled, those HTTP-related log lines are not emitted.

Changes

HTTP Logging Conditional

Layer / File(s) Summary
HTTP startup logging conditional
code/framework/src/integrations/server/instance.cpp
Startup log statements for HTTP host and port are wrapped in a conditional check for _opts.webServerEnabled, preventing spurious HTTP logs when the web server is disabled.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A rabbit hops through logs so fine,
Conditional gates keep output divine,
When servers rest, HTTP's hushed away,
Clean logs for servers that choose not to play!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding conditional logging of HTTP host and port based on web server enabled status.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant