[weather] add humidity to hourly view, fix spacing error when using UV Index, add config option to hide precipitation entries that are zero

[OWL4C]

Basically the title. Just some existing weather data included into hourly, some config option ("hideZeroes") to hide precipitation when it is zero (this actually shrinks the entire table, removing columns that are completely empty), and add a spacing column to fix the UV Index column.

I don't understand why CHANGELOG.md is broken, i accidentally did my changes to my master, so i just took the current dev branch changelog and copied it into my master changelog, added my edits, and commited. This shouldn't conflict but it does

[sdetweil]

automerge is turned off..
you have a conflict in the CHANGELOG.md

[OWL4C]

I hope this fixed it. It may have broken my fork but that is irrelevant, the changes proposed seem fine.

[rejas]

Thanks for your PR. Could you attach screenshot sof before and after your changes to this PR here?

[OWL4C]

Currently:

All functions as mentioned:

However, the need for a spacer is purely the result of a missing css class. I have thus modified the css to include a new (placeholder) class humidity-hourly, as the humidity in the current weather would also be affected by the padding.

.weather .precipitation-amount,
.weather .precipitation-prob,
.weather .humidity-hourly,
.weather .uv-index {
  padding-left: 20px;
  padding-right: 0;
}

What is the naming convention for these classes? As soon as i know what to name the placeholder i will commit a change to remove the spacer from hourly and add the new css class.
(For reference the current css without spacer would look like this:

And the css class with 20px padding looks identical to the 4em whitespace hack)

[OWL4C]

I just used the placerholder as the actual class name.

[rejas]

sorry for taking so long to review, just some minor things to finish

[rejas]

please add the new config options to the defaults object at the top of the file

[OWL4C]

Do you mean the defaults in the weather.js?

[sdetweil]

yes, it is a new config property, so it needs to havea default value set, and the defaults:{} object contains those
as documented in the developers guide for modules

[khassel]

no progress here, @rejas is the missing config.showHumidity the only thing (beside changelog merge conflicts) which is preventing this from merging?

[rejas]

besides that i had one question above...

[OWL4C]

showHumidity is a string due to current.njk implementing multiple options. I only ever implemented a binary True/False. Since js' Boolean("none") == True this will not work as intended without changes. (For that matter all strings that aren't empty are true, so it will always have to check against strings)

[OWL4C]

I changed the if to check against "none", but other than that it is still undefined what the correct string should be to turn it on, since the current.njk Humidity has multiple placements, which is inapplicable here. Since the current config comment isn't listing possible values right now, i would suggest changing it to something along the lines of // current: "none", "wind", "below"; hourly: "none", "on". While this wouldn't be clean it would work.
Alternatively it could be split into "ShowHumidity: True/False" + "CurrentHumidityPosition: wind, below" etc; whatever is preferable. Changing the comment is a band aid but works, adding options could become convoluted but has less ambiguity.

[rejas]

besides that i had one question above...

[rejas]

you'll need to move your changelog entries into the latest develop section....

[OWL4C]

Hopefully this worked? I replaced the entire file with the current one and then added back the changes
EDIT: nevermind.