Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies incl. electron to v35 #3733

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

khassel
Copy link
Collaborator

@khassel khassel commented Mar 1, 2025

No description provided.

@sdetweil
Copy link
Collaborator

sdetweil commented Mar 1, 2025

can we include @electron/rebuild as part of the base as an aide for module developers?

@khassel khassel requested a review from rejas March 1, 2025 19:44
@khassel
Copy link
Collaborator Author

khassel commented Mar 1, 2025

as an aide for module developers?

a module developer should be able to install it if he needs it.

I'm not for including because it will not work everywhere, e.g. it will not work in the normal docker images (maybe in the fat one) because using it needs compiler stuff etc.

@sdetweil
Copy link
Collaborator

sdetweil commented Mar 1, 2025

i disagree, its dependent on the electron we ship, not their fault, AND needs to be installed in the MM node_modules folder. ive made postinstall scripts to help them out, but now the module name changed , again not their fault.
if we had shipped it the module would have worked

every quarter we whack them AND the users
stability matters

@khassel
Copy link
Collaborator Author

khassel commented Mar 1, 2025

please open an issue for this to discuss, I will not change this MR, this should be merged asap as is.

@sdetweil
Copy link
Collaborator

sdetweil commented Mar 1, 2025

will, do. didn't intend it to be added here, but whats the rush? we have a month

@khassel khassel changed the title update dependencies incl. electron to v34 update dependencies incl. electron to v35 Mar 4, 2025
@khassel khassel requested review from rejas and removed request for rejas March 4, 2025 22:01
Copy link
Collaborator

@rejas rejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a month till next release indeed, but lets see if all is well with electron v35 in the meantime

@rejas rejas merged commit 1fcc028 into MagicMirrorOrg:develop Mar 5, 2025
15 of 16 checks passed
@khassel khassel deleted the update_deps branch March 5, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants